chore: fix depcheck failure from the storybook merge - #1305
Open
dorianvp wants to merge 2 commits into
Open
Conversation
reg-cli is spawned by path in visual/diff.mts, which depcheck cannot trace, so it joins the ignore list. @vitejs/plugin-react is unused: nothing imports it and no installed package declares it as a peer. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
yarn depcheckfails on every PR based ondevsince the storybook merge (#1278, commit 5bd8fc4):reg-cliis a real dependency.visual/diff.mtsspawnsnode_modules/.bin/reg-cliby path, which depcheck cannot trace. It joins the ignore list in.depcheckrc.ymlwith the reason recorded.@vitejs/plugin-reactis unused. Nothing imports it,@storybook/react-viteand@storybook/react-native-web-vite9.1.20 do not declare it as a dependency or peer, andvite-plugin-rnwbundles its own copy. Removed frompackage.jsonandyarn.lock.Test plan
yarn depcheckreports "No depcheck issue"js-depcheckjob passes🤖 Generated with Claude Code