examples/hello2: serve HTML instead of triggering a download#191
Open
glenpi wants to merge 1 commit into
Open
Conversation
setContentTypeFromPath() derives the Content-Type from the request path's file extension. For the root URL "/" there is no extension, so the response got a generic type and browsers downloaded it as a file instead of rendering the page. The handler always returns HTML, so set the content-type explicitly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running
zig build run-hello2and opening http://localhost:3000 in a browser downloads the response as a file instead of rendering the page.Cause
The handler calls
r.setContentTypeFromPath(), which derives theContent-Typefrom the request path's file extension. The root URL/has no extension, so the response gets a generic (octet-stream–like) type and browsers download it rather than rendering it.Fix
The handler always returns an HTML page regardless of path, so set the content type explicitly with
r.setContentType(.HTML).🤖 Generated with Claude Code