Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
kevwan
force-pushed
the
fix/k8s-endpointslice-rbac-error
branch
from
August 9, 2026 07:06
41411bf to
45a0695
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the Kubernetes (k8s://) zrpc resolver failure mode when EndpointSlice access is denied, making RBAC-related discovery failures easier to diagnose, and adds a brief README note documenting Kubernetes RPC discovery and required permissions.
Changes:
- Wrap EndpointSlice list “forbidden” errors with a clearer, RBAC-focused message (including required permissions).
- Refactor a few kube-builder dependencies behind package-level vars to enable targeted unit testing.
- Document Kubernetes RPC discovery target format and minimal EndpointSlice RBAC rules in
readme.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
zrpc/resolver/internal/kubebuilder.go |
Wraps EndpointSlice list RBAC errors with a clearer message and adds small seams to improve testability. |
zrpc/resolver/internal/kubebuilder_test.go |
Adds unit tests covering the new error-wrapping behavior and injected failure paths. |
readme.md |
Adds a short section describing Kubernetes RPC discovery target format and minimal EndpointSlice RBAC permissions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #5617.
The Kubernetes RPC resolver already supports
k8s://<namespace>/<service>:<port>, but when the client service account lacks permission to read EndpointSlices, the old error was misleading and looked like the service was not started.This PR improves that failure path by wrapping EndpointSlice list errors with a clearer message that points to the required RBAC permissions on
endpointslices.discovery.k8s.io(get,list,watch).It also adds a short Kubernetes RPC discovery note to
readme.mdwith the target format and the minimal RBAC example.Tests
go test ./zrpc/...go test ./zrpc/resolver/internal -run 'TestKubeBuilder|TestWrapEndpointSliceListError' -count=1