Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Aug 24, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #5707.
This PR prevents the etcd publisher from repeatedly reusing a stale cached client after watch/keepalive failures. When the publisher's keepalive channel closes or the watch stream returns an error, it now revokes the current lease and invalidates the cached etcd client before re-registering, allowing a fresh client with a valid auth token to be created.
It also adds single-resource removal support to
syncx.ResourceManager, used by the discovery registry to invalidate one cached etcd connection without closing the whole manager.Tests
Added tests:
TestResourceManager_RemoveResourceTestPublisher_keepAliveAsyncWatchErrorRefreshesClientPassed:
go test ./core/discov/... -count=1go test ./core/syncx -run TestResourceManager_RemoveResource -count=1Note:
go test ./core/syncx -count=1still fails on existing unrelated testTestImmutableResourceErrorRefreshAlways, expecting count2but got1.