refactor: extract download proxy route#546
Open
zereight wants to merge 1 commit into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #516.
Stacked on #542 because this route extraction imports
utils/download-token.tsfrom that PR.This keeps the route refactor behavior-preserving:
/downloads/:typeExpress proxy registration intodownloads/proxy.tsindex.tsinstead of importing shared server statebuildDownloadUrl()inindex.tsVerification
rtk npm run buildnode --import tsx/esm --test test/test-remote-downloads.tsnode --import tsx/esm --test test/test-job-artifacts.tstsx test/test-download-attachment.tsNote
Low Risk
Mechanical extraction with explicit dependency injection; download auth and proxy logic are unchanged aside from module boundaries.
Overview
Moves the
/downloads/:typeGitLab download proxy out ofindex.tsintodownloads/proxy.ts, with no intended behavior change.registerDownloadProxynow takes aDownloadProxyDependenciesobject (API URL defaults, dynamic API URL flag, rate limit,normalizeGitLabApiUrl,getEffectiveProjectId, HTTP agent,fetch, logger) instead of reading server globals. Both SSE and Streamable HTTP startup paths wire the same dependencies fromindex.ts.buildDownloadUrlandcreateDownloadTokenstay inindex.ts; the proxy module only importsdecryptDownloadTokenfor_tokenhandling. Auth order, per-token rate limiting, resource binding checks, download types, and streaming responses are unchanged.Reviewed by Cursor Bugbot for commit 502282a. Bugbot is set up for automated code reviews on this repo. Configure here.