feat: not persist reverse relation when withoutPersisting() mentioned#1116
Draft
mpiot wants to merge 1 commit into
Draft
feat: not persist reverse relation when withoutPersisting() mentioned#1116mpiot wants to merge 1 commit into
withoutPersisting() mentioned#1116mpiot wants to merge 1 commit into
Conversation
368afd7 to
6849117
Compare
6849117 to
d9023e1
Compare
Member
|
hey @mpiot thanks for this. Could you add a test for the problem this PR solves? so that we won't have any regression BTW, I've fixed the CI, you'll be able to rebase on 2.x once this PR is merged |
Contributor
Author
|
@nikophil I'm looking for create a test about it, just a question about the behavior:
If we want to manage FactoryD with Foundry, we need to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
try to fix #1100
On reverse relation, if the user explicitly add
withoutPersisting(), do not persist.and use #1104 to call adders ?