fix(previewer): bypass IIPImage server for simple image preview - #1315
Open
slint wants to merge 1 commit into
Open
fix(previewer): bypass IIPImage server for simple image preview#1315slint wants to merge 1 commit into
slint wants to merge 1 commit into
Conversation
slint
force-pushed
the
skip-iipimage-restricted
branch
from
March 30, 2026 21:50
acbac61 to
9b61044
Compare
ntarocco
reviewed
Apr 9, 2026
slint
force-pushed
the
skip-iipimage-restricted
branch
from
April 9, 2026 09:49
9b61044 to
6625e0c
Compare
* When we don't have tiles (e.g. for restricted records), we currently rely on nginx to interpret the 404/500 from IIPImage to fall back to the Flask application. This didn't work well in cases where IIPImage fails with a segfault or non-standard response. * We now explicitly add to the IIIF URL for the simple image preview (used for restricted records), a `__skip_image_server=1` querystring parameter, so that nginx can interpret it directly and immediately skip/fallback to the Flask IIIF serving. * We also enable buffering on nginx, so we can properly handle upstream errors and fallback properly to Flask. This is fine since tile payloads from IIPImage are relatively samll.
slint
force-pushed
the
skip-iipimage-restricted
branch
from
April 9, 2026 09:56
6625e0c to
4feee8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rely on nginx to interpret the 404/500 from IIPImage to fall back to
the Flask application. This didn't work well in cases where IIPImage
fails with a segfault or non-standard response.
(used for restricted records), a
__skip_image_server=1querystringparameter, so that nginx can interpret it directly and immediately
skip/fallback to the Flask IIIF serving.
errors and fallback properly to Flask. This is fine since tile payloads
from IIPImage are relatively samll.