Fix text finder crash from unbounded memory use#60377
Open
davidalecrim1 wants to merge 1 commit into
Open
Conversation
The text finder copied the full matched line into every match it kept, so memory grew with match count times line size and could climb into the tens of gigabytes and crash. Store only each match's position and column, render a bounded slice of the line lazily for visible rows, and cap the number of matches built while streaming using project search's existing ceiling. Fixes zed-industries#60238.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
text finder:toggle, the Zed editor will freeze. #60238.Solution
Testing
Self-Review Checklist:
Release Notes: