Restart interrupted update downloads after system wake#60366
Open
Anthony-Eid wants to merge 1 commit into
Open
Restart interrupted update downloads after system wake#60366Anthony-Eid wants to merge 1 commit into
Anthony-Eid wants to merge 1 commit into
Conversation
Promote App::on_system_wake to a multi-subscriber Subscription API (matching on_keyboard_layout_change / on_thermal_state_change) and use it in the auto-updater to cancel and restart a check or download that was interrupted by sleep, instead of letting it stall on a dead connection. This intentionally omits the reqwest read_timeout change from the reverted PR (#60301), which panicked because reqwest arms a tokio timer while polling the response body outside of any tokio runtime. A runtime-agnostic idle timeout will follow in a separate PR.
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #60301, which was reverted in #60321.
I removed the reqwest part of the fix because it crashed. reqwest's
read_timeoutrelies on a tokio timer, but Zed polls HTTP responses on gpui's executor instead of a tokio runtime, so it panicked when the response body was awaited. I'll follow up later by patching our reqwest fork to support the poll behavior we wanted.This fixes the download being stalled since we restart it when the system wakes.
I also changed
App::on_system_waketo return agpui::Subscriptionto be consistent with gpui's other on-system-event handlers likeon_keyboard_layout_changeandon_thermal_state_change.Release Notes: