csv_preview: Add row filtering feature#60339
Draft
HalavicH wants to merge 9 commits into
Draft
Conversation
08a3fc9 to
a9fe422
Compare
a9fe422 to
3e53f14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
CSV feature needs row filtering feature by column values. This PR provides base implementation of it with barebones ui.
Solution
FilterEntry/FilterEntryStatemodel intable_data_engine/filtering_by_column.rstracking per-column applied/candidate filter valuesfeat: Implement background filtering) so large CSVs don't block the UI thread while a filter is appliedFilterSortOrder, added inrenderer/settings.rs/settings.rs)GradientFade(new inui/src/components/gradient_fade.rs) to fade content behind themTesting
Filter chain tested on csv fixtures with multiple filters applied sequentially columns.
Self-Review Checklist: (todo)
Showcase
Release Notes: