Skip to content

csv_preview: Add row filtering feature#60339

Draft
HalavicH wants to merge 9 commits into
zed-industries:mainfrom
HalavicH:feat/csv-preview/add-filtering
Draft

csv_preview: Add row filtering feature#60339
HalavicH wants to merge 9 commits into
zed-industries:mainfrom
HalavicH:feat/csv-preview/add-filtering

Conversation

@HalavicH

@HalavicH HalavicH commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Objective

CSV feature needs row filtering feature by column values. This PR provides base implementation of it with barebones ui.

NOTE: Sleek UI with search & proper scrolling hanling is implemented in next PR. It's stacked on top to reduce review scope

Solution

  • New FilterEntry / FilterEntryState model in table_data_engine/filtering_by_column.rs tracking per-column applied/candidate filter values
  • Filtering runs in the background (feat: Implement background filtering) so large CSVs don't block the UI thread while a filter is applied
  • Filter menu entries reflect live counts and support a configurable sort order (FilterSortOrder, added in renderer/settings.rs / settings.rs)
  • Filter/sort trigger buttons on column headers are hidden until hover, using GradientFade (new in ui/src/components/gradient_fade.rs) to fade content behind them

Testing

Filter chain tested on csv fixtures with multiple filters applied sequentially columns.

Self-Review Checklist: (todo)

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content adheres to Zed's UI standards (UX/UI and icon guidelines)
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Showcase

image image

Release Notes:

  • Added initial row filtering UI & logic

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Jul 3, 2026
@HalavicH HalavicH force-pushed the feat/csv-preview/add-filtering branch from 08a3fc9 to a9fe422 Compare July 3, 2026 08:55
@HalavicH HalavicH force-pushed the feat/csv-preview/add-filtering branch from a9fe422 to 3e53f14 Compare July 3, 2026 09:27
@HalavicH HalavicH changed the title csv_preview: Add row filtering feature, improve UI/UX csv_preview: Add row filtering feature Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant