Fix file_type matching for local single-file worktrees#60307
Open
notpeter wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
file_typesglobs #60304Solution
Fixes custom
file_typeslanguage matching for single-file worktrees.Adds a new
file_system_abs_pathAPI with full local or remote filesystem paths for glob matching.Testing
New tests ensure
file_typestakes precedence overpath_suffixesin single file worktrees, both locally and remotely.I manually validated builds with this change are also fixed. Validation:
"file_types": {"Plain Text": ["**/.ssh/config"]}to your zed settings.json:Self-Review Checklist:
Release Notes:
file_typepath globs with single-file worktrees