Repository navigation
Conversation
…rscan source Add the ERC-7984 wrapper, the wrapper registry, the current vault batchers and the batcher router, and give the swap a direct link. Bump to 0.4.1.
Tested each path in a throwaway home: Claude Code needs a plugin update after the marketplace update, npx skills needs -g for a global install (--list only lists), Codex installs from the CLI with codex plugin add, and the Cursor path needs uv.
Give each registry-tracked contract its registry key and let the registry decide which deployment is current. Tell agents to copy only the router's token check and to keep inputs on FHE.fromExternal. Note that cUSDC is Zama's upgradeable variant, and that the compliance grants in the swap and auction belong to those apps. Reinstall the Codex plugin after an upgrade, and drop a duplicated README sentence.
The router calls the executor directly, which apps should not do, and its token check is already a rule in erc7984.md. Spell out the redeem batcher's registry key, name the deployments the registry does not track, and note that each batcher generation gets a new address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two documentation fixes after #25.
Code map: verified Etherscan links for every deployed example
The Solidity code map now links each deployed example to its verified source on Etherscan. Before this change, the swap and the batchers had only registry names, and the ERC-7984 wrappers were missing.
ConfidentialWrapper(0xe978…72B2)CONFIDENTIAL_USDCConfidentialTokenWrappersRegistry(0xeb50…bBA0)TOKEN_WRAPPER_REGISTRY0xA07c…15D5) and redeem (0x3a90…083D) batchersConfidentialSwap, proxy (0x8Fe2…8C01)CONFIDENTIAL_SWAPAuctionToken,WalletFactoryEach row names the functions worth reading, checked against the verified source:
finalizeUnwrapdeletes the request, checks the proof, then pays.Each row also gives the registry key where the registry tracks the contract, and the intro says the registry decides which deployment is current. AuctionToken and WalletFactory are named as the fixed deployments the registry does not track. The batcher row notes that each new generation gets a new address. Two notes are added:
ERC7984ERC20Wrapper.The batcher router is left out on purpose. It calls the FHEVM executor directly instead of going through the
FHElibrary, which apps should not copy, and its token check is already a rule inerc7984.md.Proxies link the proxy address, because the implementation can change on upgrade. The skill says to open the implementation from the proxy's code tab.
README: install and update commands that work as written
Every install path in the README was run as written in a throwaway home directory. These commands needed fixing:
marketplace updaterefreshes the catalog but leaves the installed plugin at its cached version. The update now also runsclaude plugin update zama-protocol@zama-skills, then a restart.npx skills:--listonly lists skills, it does not let you pick them. The command now uses-g, which installs into~/.agents/skillsand links each detected agent.--skillinstalls a single skill, andnpx skills update -gupdates.codex plugin add zama-protocol@zama-skills, and the update step runs it again aftermarketplace upgrade, because Codex caches plugins by version./pluginsstays as the alternative. The note about which files Codex reads is for maintainers and was removed.uv, and the update step is the last two commands.Verification
Code map:
ConfidentialWrapper,ConfidentialTokenWrappersRegistryandConfidentialSwap.--checks,git diff --checkand the skill validator pass. The version is bumped to 0.4.1.README, all commands ran against
zama-ai/skillsmain, each in its own throwaway home:claude plugin marketplace add,install,marketplace updateandupdatesucceed.claude plugin detailslists the three skills at 0.4.0, andclaude plugin validatepasses. The/pluginslash commands were exercised through these CLI equivalents, not inside the app.npx skills:add --list,add -g -yandupdate -g -ysucceed. The skills land in~/.agents/skillsand are linked from the agent directories.codex plugin marketplace add,codex plugin addandmarketplace upgradesucceed. The installed plugin is 0.4.0 with all three skills..cursor/rulesfolder yet.SKILL.mdfiles resolve.Not verified
Whether
codex plugin marketplace upgradealone moves an installed plugin to a new version. Codex refuses localfile://marketplaces, so this could not be tested without publishing a new version.