Repository navigation
feat(sdk): add fhevm-npm check deployments - #140
Merged
Merged
Conversation
Deployment records live in deployments/<chain>/<deploymentId>/, one folder per on-chain event, and are frozen once they land: a later event gets a new folder. `check deployments` checks every record for completeness and consistency: required files, the same deploymentId and admin in the folder name, the config and the seal, a chain folder that is a host chain of fhevm-chains.config.json with the sealed chain id, and no forge scratch or nested repository. With `--base <ref>` it also fails if a record folder that exists at the merge base changed in any way. The consistency part runs in make check-pre. deployments/README.md states the rules, and deployments/.gitignore keeps forge scratch out of commits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
manoranjith
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
fhevm-npm check deployments, the guard for a newdeployments/archive of on-chain deploymentrecords. This is the first of three PRs:
make check-pre.The model
A record is
deployments/<chain>/<deploymentId>/, copied from the operator's deployment folder once theon-chain event is final: the config the deploy tool ran with, the seal (
manifest.json), the generatedaddresses.soland the transaction journal.A record is evidence of transactions that cannot be undone, so it is frozen: once on the base branch,
nothing in it may change. A later event, such as an upgrade to v14 or an ownership change, gets a new
folder, which points at the previous seal through
previousManifest.deployments/README.mdstates therules.
The command