Repository navigation
Remove field-map copying from default request access logs - #4326
Merged
Merged
Conversation
Signed-off-by: Perfloop Agent <agent@perfloop.ai> Signed-off-by: Tomás Senart <ts@perfloop.ai>
Signed-off-by: Perfloop Agent <agent@perfloop.ai> Signed-off-by: Tomás Senart <ts@perfloop.ai>
Signed-off-by: Perfloop Agent <agent@perfloop.ai> Signed-off-by: Tomás Senart <ts@perfloop.ai>
szuecs
approved these changes
Oct 8, 2026
Member
|
👍 |
1 similar comment
Member
|
👍 |
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid building and copying field maps for default text access logs when no supplemental fields are present. Keep the existing Logrus emission path and field-based behavior for JSON, custom formatters, and supplemental fields.
Measurements
Ten paired runs per workload with
BenchmarkAccessLogWithOutput:enableAccessLog(1, 200, 3)setQuery(lang, pt), local 12-byte backendmodPathThe benchmark measures complete
Proxy.ServeHTTPcalls with synchronous access-log writes to a regular file. Setup is outside the timed loop; the query backend is warmed. B/op includes response-recorder and loopback transport/backend allocations. Production traffic weights remain unmeasured. Each row requires at least 10% lower B/op with no ns/op or allocs/op regression.Validation
Formatting, lint, logging/access-log tests, focused proxy tests, and logging/concurrent-access-log race checks passed.
TestAccessLogOnFailedRequestreturns 407 instead of 502 and leaves two persistent-connection goroutines on both the baseline and this change; the cause is unresolved. Full repository CI remains pending.make shortcheckwas not run because the Redis Testcontainers tests require Docker, which is unavailable in the sandbox.Fixes #4325
Generated by Perfloop. Human sponsor: Tomás Senart.