Repository navigation
feat(kubernetes): support paginated list requests with chunk size - #4321
Open
shardool-patil wants to merge 1 commit into
Open
shardool-patil wants to merge 1 commit into
shardool-patil wants to merge 1 commit into
Conversation
szuecs
reviewed
Oct 5, 2026
| return err | ||
| } | ||
| defer rsp.Body.Close() | ||
| defer func() { _ = rsp.Body.Close() }() |
Contributor
Author
There was a problem hiding this comment.
I did that to handle linter warning regarding the unchecked return value of Close(), so should i revert that?
szuecs
reviewed
Oct 5, 2026
| manifest, err := os.Open("testdata/routegroups/convert/missing-service.yaml") | ||
| require.NoError(t, err) | ||
| defer manifest.Close() | ||
| defer func() { _ = manifest.Close() }() |
szuecs
reviewed
Oct 5, 2026
|
|
||
| func TestAuthorizeRequestFilterWithS3DecisionLogPlugin(t *testing.T) { | ||
| t.Setenv("AWS_ACCESS_KEY_ID", "testing") | ||
| t.Setenv("AWS_SECRET_ACCESS_KEY", "testing") |
szuecs
reviewed
Oct 5, 2026
| github.com/instana/go-sensor v1.79.0 | ||
| github.com/klauspost/compress v1.20.1 | ||
| github.com/instana/go-sensor v1.77.0 | ||
| github.com/klauspost/compress v1.20.0 |
Contributor
Author
There was a problem hiding this comment.
fixed, rebased and handled the code changes across test files
szuecs
requested changes
Oct 5, 2026
shardool-patil
force-pushed
the
feat/k8s-list-chunk-size
branch
from
October 5, 2026 10:55
5f531b7 to
735bce5
Compare
shardool-patil
marked this pull request as draft
October 5, 2026 11:01
Signed-off-by: Shardool Patil <shardoolpatil999@gmail.com>
shardool-patil
force-pushed
the
feat/k8s-list-chunk-size
branch
from
October 5, 2026 11:21
735bce5 to
35f9454
Compare
shardool-patil
marked this pull request as ready for review
October 5, 2026 11:23
szuecs
approved these changes
Oct 6, 2026
szuecs
added
the
major
Member
|
Please review |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces support for paginated list requests when querying Kubernetes API resources via a new
--kubernetes-list-chunk-sizeflag and configuration parameter.Key Changes
config/config.go,skipper.go,kube.go): Added--kubernetes-list-chunk-sizeflag and wiredKubernetesListChunkSizeinto client options.dataclients/kubernetes/clusterclient.go): Implemented genericloadChunkedList[T]using Kuberneteslimitandcontinuequery parameters; keeps non-paginated behavior whenchunkSize <= 0.dataclients/kubernetes/kubernetestest): Extended test API to handle limit constraints and pagination continue tokens.Testing
clusterclient_test.goandendpointslices_test.goverifying chunked listing across Ingresses, Services, Endpoints, and EndpointSlices.chunkSize <= 0.go test -v ./dataclients/kubernetes/... ./configRelated Issues