Repository navigation
feature: new filter tokenExchange() based on rfc-8693 - #4316
Conversation
ref https://www.rfc-editor.org/rfc/rfc8693 Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
15748e8 to
b059824
Compare
|
Docker image "registry-write.opensource.zalan.do/teapot/skipper:b0598248e00f58ad4a8355f2d4f753fe3e0230b7" is not based on an approved base image. Any production deployment relying on this image will be blocked. To create a compliant Docker image of your application, you must reference an allowed Docker image as its base image in your Dockerfile. This base image must come from the Zalando Container Registry namespace |
Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
… bytes.NewReader without converting Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
…ese mandatory Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
https://github.com/zalando/skipper/pull/4316/changes#r4166621230 Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
…ed to support by Auth Server, instead of form values which is only set to MAY for auth servers. ref #4316 (comment) Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
…hServer so AuthServer would not be compliant to the RFC. Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
| for _, p := range o.CredentialsPaths { | ||
| if err := sp.Add(p); err != nil { | ||
| log.Errorf("Failed to add credentials file: %s: %v", p, err) | ||
| log.Fatalf("Failed to add credentials file: %s: %v", p, err) |
There was a problem hiding this comment.
👍 agree, it's better to fail here.
There was a problem hiding this comment.
but… tests are failing exactly because of this one :/
we miss something in tests setup, probably
there are several tests like that
Line 696 in d714bf3
There was a problem hiding this comment.
Oh, then I will create a separate PR for this kind of change, thanks for finding this. On my machine I had plugins failures for whatever reason and make clean did not fix these...
Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
…m-urlencoded. Tests failed because Go test was not reading the for value if the content-type is not correctly set. https://datatracker.ietf.org/doc/html/rfc8693#name-request also shows that application/x-www-form-urlencoded is required Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
…d as a separate PR. Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
|
👍 |
|
Docker image "registry-write.opensource.zalan.do/teapot/skipper:d82eb36fd6555854e208e6260c2e81c3b2eb9d58" is not based on an approved base image. Any production deployment relying on this image will be blocked. To create a compliant Docker image of your application, you must reference an allowed Docker image as its base image in your Dockerfile. This base image must come from the Zalando Container Registry namespace |
4 participants
ref https://www.rfc-editor.org/rfc/rfc8693