Repository navigation
Conversation
szuecs
approved these changes
Oct 3, 2026
szuecs
added
minor
MustafaSaber
reviewed
Oct 5, 2026
Signed-off-by: Shardool Patil <shardoolpatil999@gmail.com>
shardool-patil
force-pushed
the
test/ingress-status-addresses-from-service
branch
from
October 5, 2026 10:01
eb3d04c to
a8b4f32
Compare
MustafaSaber
approved these changes
Oct 5, 2026
szuecs
approved these changes
Oct 6, 2026
This was referenced Oct 6, 2026
larry-dalmeida
added a commit
to larry-dalmeida/kubernetes-on-aws
that referenced
this pull request
Oct 8, 2026
Includes zalando/skipper#4315 (background cache revalidation fix) and zalando/skipper#4314. ref: zalando/skipper@v0.28.1...v0.28.29 Signed-off-by: Larry D Almeida <hello@larrydalmeida.com>
larry-dalmeida
added a commit
to larry-dalmeida/kubernetes-on-aws
that referenced
this pull request
Oct 8, 2026
Includes zalando/skipper#4315 (background cache revalidation fix) and zalando/skipper#4314. ref: zalando/skipper@v0.28.1...v0.28.29 Signed-off-by: Larry D Almeida <hello@larrydalmeida.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds unit tests for
dataclients/kubernetesto exercise previously untested service resolution paths and error cases iningressStatusAddressesFromService:ingressStatusAddressesFromService: test empty ingress status service configuration returning nil addresses.ingressStatusAddressesFromService: test invalid namespace/name syntax error return.ingressStatusAddressesFromService: test service not found in cluster state and nil spec error handling.ingressStatusAddressesFromService: testExternalNametype with valid hostname and empty hostname returning nil.ingressStatusAddressesFromService: testClusterIPtype with valid IP, empty IP, and"None"(headless) returning nil.ingressStatusAddressesFromService: testNodePorttype withExternalIPsand fallback to endpoint addresses.ingressStatusAddressesFromService: testLoadBalancertype with ingress status (filtering entries missing both IP and hostname), fallback toExternalIPs, and empty status returning nil.ingressStatusAddressesFromService: test fallback/custom service type withExternalIPsand withoutExternalIPsreturning nil.Coverage Impact
dataclients/kubernetes/clusterclient.go:ingressStatusAddressesFromServicestatement coverage: 53.1% -> 100.0%