Skip to content

Split the CI check job into format, lint and type check - #821

Merged
yukinarit merged 2 commits into
mainfrom
ci/split-check-jobs
Nov 1, 2026
Merged

yukinarit merged 2 commits into
mainfrom
ci/split-check-jobs

Conversation

@yukinarit

Copy link
Copy Markdown
Owner

Summary

The Check formatting job ran every pre-commit hook, so a ruff or type error was reported as a formatting failure and triggered the PR comment asking contributors to format their code.

This splits it into three jobs, each backed by a make target so it can be reproduced locally:

CI job Make target Runs
Check formatting make check-format trailing-whitespace, end-of-file-fixer, black
Lint make lint ruff
Type check make typecheck pyright, mypy
  • make check still runs everything.
  • The formatting PR comment now posts only when the formatting job fails.
  • CONTRIBUTING.md documents the new targets.

Note

Check formatting keeps its name. If it is a required status check on main, Lint and Type check need adding as required too.

Test plan

  • make check-format, make lint and make typecheck pass locally
  • All three jobs run on this PR

🤖 Generated with Claude Code

yukinarit and others added 2 commits October 31, 2026 23:03
The "Check formatting" job ran every pre-commit hook, so a ruff or mypy
error was reported as a formatting failure and triggered the PR comment
asking contributors to format their code.

Run formatting, ruff, and pyright/mypy as separate jobs, each backed by a
make target so they can be reproduced locally. `make check` still runs
everything.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The workflow now covers formatting, linting and type checking as well as
tests, so name it for what it does. Prefix the test jobs with "Check" to
match, and point the README badge at the renamed file.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@yukinarit
yukinarit merged commit 42fcaa2 into main Nov 1, 2026
8 checks passed
@yukinarit
yukinarit deleted the ci/split-check-jobs branch November 1, 2026 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant