Repository navigation
Split the CI check job into format, lint and type check - #821
Merged
Merged
Conversation
The "Check formatting" job ran every pre-commit hook, so a ruff or mypy error was reported as a formatting failure and triggered the PR comment asking contributors to format their code. Run formatting, ruff, and pyright/mypy as separate jobs, each backed by a make target so they can be reproduced locally. `make check` still runs everything. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The workflow now covers formatting, linting and type checking as well as tests, so name it for what it does. Prefix the test jobs with "Check" to match, and point the README badge at the renamed file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Check formattingjob ran every pre-commit hook, so a ruff or type error was reported as a formatting failure and triggered the PR comment asking contributors to format their code.This splits it into three jobs, each backed by a make target so it can be reproduced locally:
Check formattingmake check-formatLintmake lintType checkmake typecheckmake checkstill runs everything.CONTRIBUTING.mddocuments the new targets.Note
Check formattingkeeps its name. If it is a required status check onmain,LintandType checkneed adding as required too.Test plan
make check-format,make lintandmake typecheckpass locally🤖 Generated with Claude Code