Repository navigation
skip type walk for fully custom fields - #819
Open
AllanChain wants to merge 1 commit into
Open
AllanChain wants to merge 1 commit into
AllanChain wants to merge 1 commit into
Conversation
A field with both a custom serializer and deserializer is rendered by calling those functions, so its type never appears in generated code. Walking it still auto-generates serde for nested dataclasses, which can fail on a type codegen doesn't support even though it's never used. Apply the same rule added for serde_skip in yukinarit#722 (iter_unions) and yukinarit#739 (iter_types, iter_literals). The default_* markers are excluded since they opt back into codegen, as are flattened fields, which still need the child dataclass scope.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A field with both a custom serializer and deserializer is rendered by calling those functions, so its type never appears in generated code. Walking it still auto-generates serde for nested dataclasses, which can fail on a type codegen doesn't support even though it's never used.
Apply the same rule added for serde_skip in #722 (iter_unions) and #739 (iter_types, iter_literals). The default_* markers are excluded since they opt back into codegen, as are flattened fields, which still need the child dataclass scope.
Code generated with DeepSeek Flash and get manually reviewed.