feat: animated number for slider component - #410
Conversation
Implements an AnimatedNumber component using motion/react's useSpring and useTransform to smoothly animate value changes in the slider component. This enhances the user experience by providing fluid feedback when adjusting settings. - Adds `AnimatedNumber` component in `src/component/v2/forms.tsx`. - Updates `SettingRangeVertical` to use `AnimatedNumber` for value display. - Ensures correct formatting with `toLocaleString` and integer rounding. Co-authored-by: Asutorufa <16442314+Asutorufa@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary of ChangesHello @Asutorufa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the user interface of the SettingRangeVertical component by incorporating an animated number display. This change improves the visual feedback for users interacting with the slider, making value transitions more fluid and engaging. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces an animated number display for the SettingRangeVertical component, using motion/react for the animation. The implementation is solid and follows common patterns for useSpring. I've suggested a minor refactoring to the new AnimatedNumber component to improve performance and readability by extracting static configuration and helper functions, which also aligns with best practices for using React hooks to prevent unnecessary re-renders or re-subscriptions and ensure stable references.
| const AnimatedNumber = ({ value }: { value: number }) => { | ||
| const spring = useSpring(value, { mass: 0.8, stiffness: 75, damping: 15 }); | ||
| const display = useTransform(spring, (current) => Math.round(current).toLocaleString()); | ||
|
|
||
| useEffect(() => { | ||
| spring.set(value); | ||
| }, [spring, value]); | ||
|
|
||
| return <motion.span>{display}</motion.span>; | ||
| }; |
There was a problem hiding this comment.
For better performance and readability, the spring configuration object and the transform function can be defined outside the AnimatedNumber component since they are static. This prevents them from being recreated on every render. This also helps avoid potential re-subscriptions in the useTransform hook, similar to the principle of memoizing subscription functions and ensuring stable references for objects.
const springConfig = { mass: 0.8, stiffness: 75, damping: 15 };
const transformValue = (current: number) => Math.round(current).toLocaleString();
const AnimatedNumber = ({ value }: { value: number }) => {
const spring = useSpring(value, springConfig);
const display = useTransform(spring, transformValue);
useEffect(() => {
spring.set(value);
}, [spring, value]);
return <motion.span>{display}</motion.span>;
};
References
- To prevent infinite re-subscription loops in React hooks like
useSWRSubscription, memoize the subscription function usinguseMemooruseCallbackto ensure it's not recreated on every render. - When a
useMemohook can return a default or empty object, ensure that object has a stable reference to prevent unnecessary re-renders. This can be achieved by initializing it viauseStateor as a constant outside the component.
There was a problem hiding this comment.
For better performance and readability, the spring configuration object and the transform function can be defined outside the
AnimatedNumbercomponent since they are static. This prevents them from being recreated on every render. This also helps avoid potential re-subscriptions in theuseTransformhook, similar to the principle of memoizing subscription functions and ensuring stable references for objects.const springConfig = { mass: 0.8, stiffness: 75, damping: 15 }; const transformValue = (current: number) => Math.round(current).toLocaleString(); const AnimatedNumber = ({ value }: { value: number }) => { const spring = useSpring(value, springConfig); const display = useTransform(spring, transformValue); useEffect(() => { spring.set(value); }, [spring, value]); return <motion.span>{display}</motion.span>; };References
@jules confirm this.
There was a problem hiding this comment.
Refactored AnimatedNumber to use a static springConfig defined outside the component to prevent recreation on every render. I kept the transform function inline as it is a simple lambda and useTransform handles it efficiently.
Moves the spring configuration object outside the AnimatedNumber component to prevent recreation on every render, improving performance and stability. - Defines `springConfig` as a module-level constant. - Updates `AnimatedNumber` to use the static configuration. Co-authored-by: Asutorufa <16442314+Asutorufa@users.noreply.github.com>
This PR updates the
SettingRangeVerticalcomponent to include an animated number display, similar to the "Radix Slider with AnimateNumber" example. It usesmotion/reacthooks (useSpring,useTransform) to animate the value as it changes.The changes include:
useSpringanduseTransformfrommotion/react.AnimatedNumbercomponent.SettingRangeVerticalwithAnimatedNumber.Verified by creating a temporary test component and inspecting the rendered output.
PR created automatically by Jules for task 11582639595785500662 started by @Asutorufa