Repository navigation
fix: match a continued thread's project by its whole name - #81
Merged
Merged
Conversation
threadMatchesProject tested the project name as a suffix of the thread URL's project segment, so "Notes" also matched "g-p-<id>-my-notes". --continue (and MCP continue_thread) uses it when the sidebar gave no id and no recorded thread carries exactly that name; the follow-up then continued the other project's conversation, and since a continued thread is pinned, the project step that would have caught it is skipped. The name must now be all of what follows the id in the segment. Verified: tsc, build, npm test (1842 passed, 3 skipped); the new test fails without the change. Spot check on the built module: for "Notes", notes=true, my-notes=false, notes-archive=false. Not reproduced live, which would take creating look-alike projects in the account. Claude-Session: https://claude.ai/code/session_01EMqNwnnhHXznd2P2PDsaDV
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
What this touches
3 file(s), 24 line(s) changed. Tests changed. This is an automated first pass, not a review. CI is the gate; a person decides. |
…suffix # Conflicts: # CHANGELOG.md
youdie006
added a commit
that referenced
this pull request
Oct 30, 2026
…he container image --continue matched the project as a suffix of the thread URL's project segment, so "Notes" also matched "my-notes" and a follow-up could go into another project's conversation when the sidebar gave no id. The name must now be all that follows the id. The patch from main applied as-is. Verified: tsc, build, npm test (2154 passed, 3 skipped). Claude-Session: https://claude.ai/code/session_01EMqNwnnhHXznd2P2PDsaDV
youdie006
added a commit
that referenced
this pull request
Oct 30, 2026
Merging PR #83 after #79-#81 left two "## Unreleased / ### Fixed" headings: git joined the branch's new section and main's without a conflict. The four entries are now one list. Claude-Session: https://claude.ai/code/session_01EMqNwnnhHXznd2P2PDsaDV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
threadMatchesProjecttested the project name as a suffix of the thread URL's project segment, so--project Notesalso matched a thread of a project called "My Notes" (/g/g-p-<id>-my-notes/c/...).--continue(and MCPcontinue_thread) uses this match when the sidebar gave no project id and no recorded thread carries exactly that name. In that case the follow-up continued the other project's conversation. A continued thread is pinned, which skips the project step, so nothing later caught it and the prompt went into the other project.Change
The name must be all of what follows the id in the segment (
^g-p-<hex>-(name)$). An id-only segment still falls back to the recorded project ids as before.Verification
tsc --noEmit,npm run build,npm test: 1842 passed, 3 skipped.tests/continue-thread.test.ts:my-notes;resolveContinuationThreadrefuses instead of picking the other project's thread.