Skip to content

fix: keep table column alignment in answers - #78

Merged
youdie006 merged 2 commits into
mainfrom
fix/answer-table-alignment
Oct 29, 2026
Merged

youdie006 merged 2 commits into
mainfrom
fix/answer-table-alignment

Conversation

@youdie006

Copy link
Copy Markdown
Owner

Problem

ChatGPT's newer answer renderer marks a column written :---, :---: or ---: with data-d-align start, center or end on each of its cells, and leaves a plain column unmarked (measured 2026-10-29). The answer reader wrote every separator as ---, so a right-aligned column of numbers came back left-aligned.

Change

table() in CHATGPT_RENDERED_MESSAGE_TEXT_JS builds the separator row from the header cells' data-d-align. Unmarked columns stay ---, so tables without alignment read as before.

Verified

  • New test in tests/answer-markdown.test.ts (failed before the fix).
  • npx tsc --noEmit; npm test: 147 files, 1827 passed, 3 skipped.
  • Live, Instant, branch build: a table with plain, left, center and right columns came back with | --- | :--- | :---: | ---: |; 0.40.47 returned four ---.

Claude-Session: https://claude.ai/code/session_01EMqNwnnhHXznd2P2PDsaDV

ChatGPT's newer answer renderer marks a column written :---, :---: or
---: with data-d-align start, center or end on each of its cells, and a
plain column with none (measured 2026-10-29). The reader wrote every
separator as ---, so a right-aligned column came back left-aligned. The
separator row now follows the header cells' alignment.

Verified: a failing test first, then tsc --noEmit and npm test (147
files, 1827 passed, 3 skipped). Live, Instant, branch build: a table with
plain, left, center and right columns came back with
"| --- | :--- | :---: | ---: |", where 0.40.47 returned four ---.

Claude-Session: https://claude.ai/code/session_01EMqNwnnhHXznd2P2PDsaDV
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T03:47:11.208828Z 76a8820 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

What this touches

  • browser adapter
  • tests

3 file(s), 30 line(s) changed. Tests changed.

This is an automated first pass, not a review. CI is the gate; a person decides.

@youdie006
youdie006 merged commit 7a88f85 into main Oct 29, 2026
7 checks passed
youdie006 added a commit that referenced this pull request Oct 29, 2026
The separator row of an answer's table follows the cells' data-d-align
(start, center, end) instead of writing --- for every column.

Verified on this commit, with the #74-#77 ports below it: tsc --noEmit,
build, npm test (166 files, 2144 passed, 3 skipped) and
npm run release:verify.

Claude-Session: https://claude.ai/code/session_01EMqNwnnhHXznd2P2PDsaDV
youdie006 added a commit that referenced this pull request Oct 29, 2026
Release commit 406ae25 (PRs #74-#78), publish run 40819980786, installs
on WSL, M3 and the Mac mini, the maintainer checkout, the container
branch ports, and the live checks on the installed build.

Claude-Session: https://claude.ai/code/session_01EMqNwnnhHXznd2P2PDsaDV
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant