Repository navigation
fix: keep inline code that holds a backtick intact in answers - #77
Merged
Merged
Conversation
The answer reader wrapped inline code in one backtick on each side, so the code a`b came back as `a`b`, which markdown reads as a one-letter span and a stray backtick (measured 2026-10-29: the page showed the codes ``a`b`` and ``echo `date` ``). Inline code now goes in a backtick run longer than any inside it, padded with a space when it starts or ends with a backtick or has a space at both ends that markdown would strip, as CommonMark specifies. Verified: failing tests first, then tsc --noEmit and npm test (147 files, 1829 passed, 3 skipped; one earlier full run failed browser-slow-vs-dead's tiny-timeout case under load, which passed three times alone and in the rerun). Live, Instant, branch build: the answer came back as "Run ``echo `date` `` to print the date, or ``a`b`` for short.", matching what the page showed. Claude-Session: https://claude.ai/code/session_01EMqNwnnhHXznd2P2PDsaDV
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
What this touches
3 file(s), 36 line(s) changed. Tests changed. This is an automated first pass, not a review. CI is the gate; a person decides. |
…e-backticks # Conflicts: # CHANGELOG.md
youdie006
added a commit
that referenced
this pull request
Oct 29, 2026
…r image Inline code goes in a backtick run longer than any inside it, padded where CommonMark needs a space. Verified: tsc --noEmit; tests/answer-markdown.test.ts passes. The full suite runs after the last port in this batch. Claude-Session: https://claude.ai/code/session_01EMqNwnnhHXznd2P2PDsaDV
youdie006
added a commit
that referenced
this pull request
Oct 29, 2026
The separator row of an answer's table follows the cells' data-d-align (start, center, end) instead of writing --- for every column. Verified on this commit, with the #74-#77 ports below it: tsc --noEmit, build, npm test (166 files, 2144 passed, 3 skipped) and npm run release:verify. Claude-Session: https://claude.ai/code/session_01EMqNwnnhHXznd2P2PDsaDV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The answer reader wrapped inline code in one backtick on each side. Measured 2026-10-29: the page showed the inline codes
``a`b``and``echo `date` ``, and the answer came back as`a`b`and`echo `date` `. Markdown reads those as different spans with stray backticks between them.Change
inlineCode()inCHATGPT_RENDERED_MESSAGE_TEXT_JSfollows CommonMark:Plain inline code is unchanged.
Verified
tests/answer-markdown.test.ts. The two backtick cases failed before the fix, with the live output.npx tsc --noEmit;npm test: 147 files, 1829 passed, 3 skipped. One earlier full run failed the tiny-timeout case inbrowser-slow-vs-dead.test.tsunder load; it passed three times alone and in the rerun.Runechodateto print the date, ora`bfor short., matching the page.Claude-Session: https://claude.ai/code/session_01EMqNwnnhHXznd2P2PDsaDV