Repository navigation
fix: say the answering model is unknown when ChatGPT does not name it - #112
Merged
Merged
Conversation
ChatGPT stopped rendering data-message-model-slug (measured 2026-11-17 on the live container tab; neither the answer's buttons nor its More actions menu name a model), so model_used and pro_verified were silently missing and a Pro consult could not be told from an unchecked one. prodex reads rendered page content only, so the model cannot be read. model_used is now "unknown" in that case, a model_unverified warning says why pro_verified is left out, and picker_effort records the step the picker's effort slider read once prodex had set it, before the prompt was typed. The slider walk already confirmed that reading and discarded it. Claude-Session: https://claude.ai/code/session_01EMqNwnnhHXznd2P2PDsaDV
What this touches
8 file(s), 143 line(s) changed. Tests changed. This is an automated first pass, not a review. CI is the gate; a person decides. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
youdie006
added a commit
that referenced
this pull request
Nov 18, 2026
fix: port main PR #112 (say the answering model is unknown when ChatGPT does not name it) to the container image
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Consult answers came back with
model_usedandpro_verifiedmissing. A session that asked for Pro could not prove the answer came from Pro, and the response gave no reason, so "not checked" and "cannot be checked" looked the same.Cause, measured 2026-11-17 on the live WSL container tab (read-only):
data-message-model-slug. The page had none, and no other attribute matchedmodelorslug.prodex reads rendered page content only (README "What it will not do", SECURITY.md,
tests/architecture-boundaries.test.ts), so the answering model cannot be read. This change does not reverse that.Change
model_usedis"unknown"when the page does not name the model. This applies to the CLI JSON, the MCPpro_consultresponse, theconsult_answer_savedreceipt and themodel_used:line.model_unverifiedwarning says whypro_verifiedis left out.picker_effortfield records the step the picker's effort slider read once prodex had moved it, before the prompt was typed. The slider walk already confirmed this reading and then discarded it. It shows what was selected, not what answered, and the warning says so.model_usedandpro_verifiedare filled from it as before.docs/clients.mdand the MCPallow_model_fallbackdescription name the new field and value.Verified
tests/chatgpt-browser.test.ts"returns the step the power slider read once the walk reached it"tests/mcp-consult.test.ts"says the answering model is unknown when the page does not name it, and shows what the picker read"tests/cli-pro-browser-send.test.tsnow include the new warning for untagged answers.npx tsc --noEmitclean.npm run release:verify(npm test, typecheck, build, package smoke, doctor) passed:release_verification=ok. The first full run, before the two expectations were updated, failed exactly those two tests (2006 passed, 2 failed).