Repository navigation
fix: give the suite 25 minutes in release:verify and say when a check ran out - #100
Merged
Merged
Conversation
… ran out The 0.40.51 publish run (42733208248) failed on two runners with no product defect: - macOS Intel: release:verify stopped `npm test` at its 15 minute budget. It reported "release verification failed: npm test: > @youdie006/ prodex@0.40.51 test", npm's banner line, as if a test had failed. CI's macOS Intel runners had taken 10.5 to 14 minutes for the suite; on main 52f76d6 the whole release:verify took 12m53s. - Windows: launch-port-unavailable's "ends the browser it started" test waited a fixed 200 ms after the browser was closed for the child's exit event, and the event had not arrived (the test took 612 ms in all). Changes: - The suite gets 25 minutes (CI's job limit is 40), and PRODEX_RELEASE_CHECK_TEST_TIMEOUT_MS sets another budget. - A check stopped at its budget is reported as stopped, with the budget. - The launch test awaits the exit event for up to 5 s. With the browser left running (endLaunchedBrowser call removed) it still fails, after 5 s. Verified: the new release-check test failed first (the budget could not be set, so the check ran into the test's 30 s limit) and passes now; tsc clean; npm run release:verify ok on this branch. Claude-Session: https://claude.ai/code/session_01EMqNwnnhHXznd2P2PDsaDV
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
What this touches
5 file(s), 101 line(s) changed. Tests changed. Worth a look
This is an automated first pass, not a review. CI is the gate; a person decides. |
youdie006
added a commit
that referenced
this pull request
Nov 10, 2026
0.40.51 (#88-#99) published and installed on WSL, M3 and the Mac mini; M4 was unreachable. The publish run's first attempt failed on macOS Intel (the suite's 15 minute budget) and Windows (a fixed 200 ms wait in a test); the failed jobs passed on rerun, and both causes were fixed in #100. Both browser containers now run 88a8d96. M3's colima VM had been stopped since M3 restarted and was started for the swap. Includes the live check of #96's stdio limit on the WSL container. Claude-Session: https://claude.ai/code/session_01EMqNwnnhHXznd2P2PDsaDV
youdie006
added a commit
that referenced
this pull request
Nov 17, 2026
0.40.52 (51da80d, PRs #100 and #105-#109) published on its first publish run and is installed on WSL, M3 and the Mac mini; the MacBook M4 did not answer ssh and still runs 0.40.51. The browser containers on WSL and M3 were rebuilt twice: from 58650ce (container PR #110), which fixes the request_mismatch every container consult hit once ChatGPT keyed transcript units by turn id, and then from 9969a64 (container PR #111), which ports this release's fixes. Each swap was gated on the send lock, and a smoke consult answered with its request verified on both hosts after each. Claude-Session: https://claude.ai/code/session_01EMqNwnnhHXznd2P2PDsaDV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What failed
The 0.40.51 publish run (42733208248) failed on two runners. Neither failure was a product defect.
release:verifystoppednpm testat its 15 minute budget (started 01:06:31, stopped 01:21:32 UTC). It reportedrelease verification failed: npm test: > @youdie006/prodex@0.40.51 test, npm's banner line, as if a test had failed. CI's macOS Intel runners had taken 10.5 to 14 minutes for the suite. On main52f76d6, the wholerelease:verifytook 12m53s.tests/launch-port-unavailable.test.ts, "ends the browser it started" waited a fixed 200 ms after the browser was closed. The child's exit event had not arrived by then; the test took 612 ms in all.Changes
scripts/release-check.mjs:npm testgets 25 minutes; CI's job limit is 40.PRODEX_RELEASE_CHECK_TEST_TIMEOUT_MSsets another budget.stopped after its <budget> time budget, instead of quoting its first output line.Verified
endLaunchedBrowsercall removed, it still fails, after 5 s.tscis clean, andnpm run release:verify(the full suite and the package smoke) passes on this branch locally.The 0.40.51 publish run was rerun for its failed jobs separately, because the tag's commit cannot take this change.