Cleanup for custom frame range option in local rendering - #252
Cleanup for custom frame range option in local rendering #252moonyuet wants to merge 11 commits into
Conversation
…collector in core addon
There was a problem hiding this comment.
Pull request overview
This PR refactors how Deadline JobInfo “custom frames” are collected, aiming to support the custom frame range option for local rendering workflows by sourcing frame overrides from instance data rather than the plugin’s publish-attribute UI.
Changes:
- Switched custom frame collection to read from
instance.data(custom_frames/reuse_last_version) instead of publish attributes. - Removed the custom-frames publish attribute definitions and their create-context change callbacks from
CollectJobInfo.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
NOTE: Don't change anything yet, this is discussion! I don't think this can be done this way. Deadline plugin is shown for maya, houdini, nuke and few others, but we have over 20 hosts, and they don't support custom frame ranges. Also the list of families should not be requirement. I'm afraid this can't be solved with one generic plugin that is shown for all instances. If we want to move it from deadline, I'm afraid it must be added by the hosts themselves, we can prepare a plugin base in ayon-core to avoid duplication of code , but it would be just pre-implemented class in pipeline that has to be imported in the host itself with filtering the host defines on it's own. Also consider that it would make more sense to have this in create attributes instead of publish attributes. @antirotor @BigRoy opinions? |
|
I didn't understand the description completely, but this is probably tied to #57 We should definitely tackle it, but not sure, if this PR is good approach. |
|
Oh, actually this PR might be in a opposite way than I understood. So I don't understand what should be a goal completely ;). |
…upport-for-Local-Rendering
…upport-for-Local-Rendering
|
The goal is that we should move the logic of custom frames from deadline addon to core. But we have to keep compatibility. Don't know how to achieve that at this moment. We have to first resolve the ayon-core PR which might take some time as current state is not mergable, we have to figure out the families thing in there first. |
…upport-for-Local-Rendering
…upport-for-Local-Rendering
…ike pathlib to write pre-load script
|
Recently re-tested together with |

Changelog Description
This PR is to add cleanup for custom frame range option to support not only farm but local rendering.
Additional review information
Need to test with core addon ynput/ayon-core#1818
Testing notes: