Skip to content

Cleanup for custom frame range option in local rendering - #252

Open
moonyuet wants to merge 11 commits into
developfrom
enhancement/YN-0726--Custom-Frame-Range-Support-for-Local-Rendering
Open

Cleanup for custom frame range option in local rendering #252
moonyuet wants to merge 11 commits into
developfrom
enhancement/YN-0726--Custom-Frame-Range-Support-for-Local-Rendering

Conversation

@moonyuet

@moonyuet moonyuet commented May 8, 2026

Copy link
Copy Markdown
Member

Changelog Description

This PR is to add cleanup for custom frame range option to support not only farm but local rendering.

Additional review information

Need to test with core addon ynput/ayon-core#1818

Testing notes:

  1. Create Render with option of local/farm rendering
  2. Should be working

@moonyuet moonyuet added type: enhancement Improvement of existing functionality or minor addition sponsored This is directly sponsored by a client or community member labels May 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors how Deadline JobInfo “custom frames” are collected, aiming to support the custom frame range option for local rendering workflows by sourcing frame overrides from instance data rather than the plugin’s publish-attribute UI.

Changes:

  • Switched custom frame collection to read from instance.data (custom_frames / reuse_last_version) instead of publish attributes.
  • Removed the custom-frames publish attribute definitions and their create-context change callbacks from CollectJobInfo.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread client/ayon_deadline/plugins/publish/global/collect_jobinfo.py Outdated
Comment thread client/ayon_deadline/plugins/publish/global/collect_jobinfo.py Outdated
Comment thread client/ayon_deadline/plugins/publish/global/collect_jobinfo.py
Comment thread client/ayon_deadline/plugins/publish/global/collect_jobinfo.py Outdated
Comment thread client/ayon_deadline/plugins/publish/global/collect_jobinfo.py Outdated
@iLLiCiTiT

iLLiCiTiT commented May 11, 2026

Copy link
Copy Markdown
Member

NOTE: Don't change anything yet, this is discussion!

I don't think this can be done this way. Deadline plugin is shown for maya, houdini, nuke and few others, but we have over 20 hosts, and they don't support custom frame ranges. Also the list of families should not be requirement. I'm afraid this can't be solved with one generic plugin that is shown for all instances.

If we want to move it from deadline, I'm afraid it must be added by the hosts themselves, we can prepare a plugin base in ayon-core to avoid duplication of code , but it would be just pre-implemented class in pipeline that has to be imported in the host itself with filtering the host defines on it's own.

Also consider that it would make more sense to have this in create attributes instead of publish attributes.

@antirotor @BigRoy opinions?

Comment thread client/ayon_deadline/plugins/publish/global/collect_jobinfo.py Outdated
@kalisp

kalisp commented May 11, 2026

Copy link
Copy Markdown
Member

I didn't understand the description completely, but this is probably tied to #57

We should definitely tackle it, but not sure, if this PR is good approach.

@kalisp

kalisp commented May 11, 2026

Copy link
Copy Markdown
Member

Oh, actually this PR might be in a opposite way than I understood.
I thought this should be removing Custom Frames from local rendering (eg not showing field for local instances), but it seems that it is moving it to support it even for local rendering.

So I don't understand what should be a goal completely ;).

@LiborBatek LiborBatek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for both local and farm rendering!

Image

@iLLiCiTiT

Copy link
Copy Markdown
Member

The goal is that we should move the logic of custom frames from deadline addon to core. But we have to keep compatibility. Don't know how to achieve that at this moment. We have to first resolve the ayon-core PR which might take some time as current state is not mergable, we have to figure out the families thing in there first.

@moonyuet moonyuet added type: enhancement Improvement of existing functionality or minor addition and removed type: enhancement Improvement of existing functionality or minor addition labels Aug 11, 2026
@moonyuet moonyuet removed the type: enhancement Improvement of existing functionality or minor addition label Aug 14, 2026
@moonyuet moonyuet added the type: enhancement Improvement of existing functionality or minor addition label Aug 14, 2026
@LiborBatek

Copy link
Copy Markdown
Member

Recently re-tested together with 3dsmax and Vray and all been working correctly...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sponsored This is directly sponsored by a client or community member type: enhancement Improvement of existing functionality or minor addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants