Maya: Fix submission of tile renders - #156
Draft
BigRoy wants to merge 2 commits into
Draft
Conversation
| new_job_info.update(tiles_data["JobInfo"]) | ||
| for key, value in tiles_data.items(): | ||
| setattr(new_job_info, key, value) | ||
| new_plugin_info.update(tiles_data["PluginInfo"]) |
Member
There was a problem hiding this comment.
I wonder if it'll fail here?
There's another new_plugin_info.update
Member
Author
There was a problem hiding this comment.
new_plugin_info is still a dict only Job info turned into an object.
Member
There was a problem hiding this comment.
isn't that also updating the data of tile_data["PluginInfo"] into the job_info?
Member
Author
|
@ralphmeijerambassadors this PR may be a starting point for you. |
|
Thanks! I will take a look. Currently internally this doesn't have a high priority but will look into this. |
Member
|
@BigRoy Just out of curiosity. Although it doesn't seem to be at the priority. is it ready for review or we still have the discussion about the changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Fix submitting of tiled renders from maya.
Additional review information
Initial draft to try and fix Tile Rendering in Maya submissions
Fix:
Reported here.
However, this now passes that - but fails on:
I'm not sure how this was done before?
Testing notes: