-
Notifications
You must be signed in to change notification settings - Fork 1
Implementation of publishing vdb product #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
moonyuet
wants to merge
8
commits into
develop
Choose a base branch
from
enhancement/AY-7855_Exporting-VDBs-with-the-tyFlow-Export-VDB
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
694c178
implement vdb product for publishing with tyflow
moonyuet daaf39e
fix the error encountered during creating and publishing instances
moonyuet b2248ff
make sure everything published successfully
moonyuet f9f0f7f
make sure vdb product align with the product type vdbcache from other…
moonyuet 1db24c2
edit the setting for validate vdb frame range
moonyuet 11539f9
Merge branch 'develop' into enhancement/AY-7855_Exporting-VDBs-with-t…
moonyuet ef7b299
work in progress to implment the published families
moonyuet 2fa72be
wip vdb publish for tyflow
moonyuet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,3 +9,11 @@ class CreateTyFlow(plugin.MaxCacheCreator): | |
| label = "TyFlow" | ||
| product_type = "tyflow" | ||
| icon = "gear" | ||
|
|
||
|
|
||
| class CreateTyVDB(plugin.MaxTyflowVDBCacheCreator): | ||
| """Creator plugin for TyFlow VDB.""" | ||
| identifier = "io.ayon.creators.max.vdb" | ||
| label = "VDB (TyFlow)" | ||
| product_type = "tyflow_vdb" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note that a lot of VDB based loaders currently target the For example, these all target |
||
| icon = "gear" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why
"OP Data"?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the name of general container attributes for other product type. It would be renamed after the related PR for this issue as the backward compatibility needs to be implemented for this.