-
Notifications
You must be signed in to change notification settings - Fork 1
Implementation of validator for active viewport #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
moonyuet
wants to merge
9
commits into
develop
Choose a base branch
from
bugfix/165-Validate-Render-Active-Viewport-Used
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+58
−0
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
6221a95
implement the validator to check whether the active viewport is enabled
moonyuet 1cd7d6c
add more descriptive message
moonyuet 6fc253f
Update client/ayon_max/plugins/publish/validate_render_active_viewpor…
moonyuet a0ace82
add description slot
moonyuet 8de2c89
Merge branch 'bugfix/165-Validate-Render-Active-Viewport-Used' of htt…
moonyuet 9e90ab6
Update client/ayon_max/plugins/publish/validate_render_active_viewpor…
moonyuet d1cdfaf
Apply suggestion from @moonyuet
moonyuet 714a574
remove the update render dialog and implement the right logic for ren…
moonyuet f4b309a
Merge branch 'bugfix/165-Validate-Render-Active-Viewport-Used' of htt…
moonyuet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
49 changes: 49 additions & 0 deletions
49
client/ayon_max/plugins/publish/validate_render_active_viewport.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| """Validates whether the render active viewport is set in render settings.""" | ||
| import pyblish.api | ||
| from ayon_core.pipeline import ( | ||
| PublishValidationError, | ||
| OptionalPyblishPluginMixin, | ||
| ) | ||
| from ayon_core.pipeline.publish import RepairAction | ||
| from pymxs import runtime as rt | ||
|
|
||
|
|
||
| class ValidateNoActiveViewport(pyblish.api.ContextPlugin, | ||
| OptionalPyblishPluginMixin): | ||
| """Validates No Active Viewport | ||
|
|
||
| Check if there is no active viewport set in the render settings. | ||
| """ | ||
|
|
||
| order = pyblish.api.ValidatorOrder | ||
| families = ["maxrender"] | ||
| hosts = ["max"] | ||
| label = "No Render Active Viewport" | ||
| optional = False | ||
| actions = [RepairAction] | ||
|
|
||
| def process(self, context): | ||
| if not self.is_active(context.data): | ||
| return | ||
| if not rt.rendUseActiveView: | ||
| raise PublishValidationError( | ||
| title="No Active Render Viewport", | ||
| message=( | ||
| "The render active viewport is currently disabled " | ||
| "in the render settings. Please use the repair action " | ||
| "to activate it." | ||
| ), | ||
| description=( | ||
| "## Render Active Render Viewport\n" | ||
| "The render active viewport is currently " | ||
| "disabled in the render settings.\n\n" | ||
| "We need to enable the render active viewport " | ||
| "to ensure the correct render viewport is used.\n\n" | ||
| "You can use the repair action to activate it." | ||
| ) | ||
|
|
||
| ) | ||
|
|
||
| @classmethod | ||
| def repair(cls, context): | ||
| rt.rendUseActiveView = True | ||
|
moonyuet marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.