add get publish families function by moonyuet · Pull Request #163 · ynput/ayon-3dsmax

moonyuet · 2026-09-04T11:54:34Z

Changelog Description

This PR is to implement the get_published_families in Max Creator and add custom.frame.range as part of the published families in Render Creator.

Additional review information

Tested with core: ynput/ayon-core#2040 and deadline: ynput/ayon-deadline#252

Testing notes:

Tested with the custom frame range
It would work.

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

iLLiCiTiT · 2026-09-04T12:20:52Z

            created_instance = CreatedInstance.from_existing(
-                read(rt.GetNodeByName(instance)), self
-            )
+                read(rt.GetNodeByName(instance)), self)


The suggestion did not remove the original creation of instance

There is some issue hit when resolving the syntax error on the code. Should be fixed in 41e0b0e

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

…tead doing it in collecting instances

BigRoy

Looking pretty good - still think there's no reason to store families data into the scene file.

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

BigRoy

Just need to update what we pass to imprint.

Also, the same should be applied here: https://github.com/ynput/ayon-3dsmax/pull/163/changes#diff-0631ddaff52c19c6bda2ab647fd5953ddec3cb53f5a999cce3ed6ee5f38d66cfR475

What I did in other integrations was have just a def imprint_instance_node(self, node, data): or alike on the plug-in that both would call, to then strip out the instance specific data.

Both collect and update instances would then imprint the data using that one.

This gives you the benefit that if a subclass has additional metadata that you don't want to store, you just override it's imprint_instance_node method to add some data changing before hand, regardless of where you're imprinting.

BigRoy · 2026-09-07T10:33:49Z

Above comment is still valid - still lacking on collect as pointed out here

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

BigRoy

LGTM - needs testing by @LiborBatek

Should also probably test publishing in general.

Copilot

🟡 Changes recommended

There are confirmed robustness/behavior issues in creator collection/imprinting (missing node guard; in-place data mutation; inconsistent application of published families during create) that can break instance discovery or make get_published_families() unreliable.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR introduces a get_published_families() hook on 3ds Max creators and uses it to attach an additional family (custom.frame.range) to Render instances, enabling downstream publish plugins (e.g., custom frame-range collection) to match against that family.

Changes:

Added get_published_families() to the Max creator base and applied it during instance collection.
Updated imprinting to go through a dedicated helper (imprint_instance_node) and refactored cache creator inheritance to reuse MaxCreator behavior.
Updated Render creator to publish custom.frame.range alongside maxrender.

File summaries

File	Description
`client/ayon_max/plugins/create/create_render.py`	Adds a `get_published_families()` override so Render instances include `custom.frame.range`.
`client/ayon_max/api/plugin.py`	Adds/uses `get_published_families()` in creator collection and centralizes imprinting behavior via a helper method.

Review details

Files reviewed: 2/2 changed files
Comments generated: 3
Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

BigRoy · 2026-09-07T12:07:03Z

        self._add_instance_to_context(instance)
-        imprint(instance_node.name, instance.data_to_store())
+        self.imprint_instance_node(instance_node.name, instance.data_to_store())


This does indeed seem to be lacking. The publish families is lacking to be applied around line 358?

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

LiborBatek

I have tested both local render and farm render and also using both RShift and Vray...

The publishes were succesful and properly integrated on AYON.

There was an issue with render camera while rendering on farm tho (and obviously not accidental as it appeared in both RShift and Vray) as my camera was switched to top view for some reason...

Correct one PhysCamera001

While when farm rendered (I gues orthographic Top camera)

Im also enclosing full json publish report (which was succesful)

max-Vray-publish-report-260908-12-43.json.txt

LiborBatek

It works...we have found it was the corrupted scene causing the issues with camera.

Its working for both local render and farm render

LGTM!

moonyuet added 2 commits September 4, 2026 19:47

add get publish families function

29e2c73

add custom.frame.range as families

38c340f

moonyuet mentioned this pull request Sep 4, 2026

Custom frame range: Plugin works with specific family ynput/ayon-core#2040

Open

moonyuet self-assigned this Sep 4, 2026

moonyuet added type: enhancement Improvement of existing functionality or minor addition sponsored This is directly sponsored by a client or community member labels Sep 4, 2026

iLLiCiTiT reviewed Sep 4, 2026

View reviewed changes

Comment thread client/ayon_max/api/plugin.py Outdated

iLLiCiTiT reviewed Sep 4, 2026

View reviewed changes

Comment thread client/ayon_max/api/plugin.py Outdated

iLLiCiTiT reviewed Sep 4, 2026

View reviewed changes

Comment thread client/ayon_max/api/plugin.py Outdated

moonyuet and others added 3 commits September 4, 2026 20:04

Update client/ayon_max/api/plugin.py

263af34

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

Update client/ayon_max/api/plugin.py

ced533e

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

fix syntax error

a268268

iLLiCiTiT reviewed Sep 4, 2026

View reviewed changes

remove the duplicated code

41e0b0e

BigRoy requested changes Sep 4, 2026

View reviewed changes

Comment thread client/ayon_max/api/plugin.py Outdated

Comment thread client/ayon_max/api/plugin.py Outdated

Comment thread client/ayon_max/api/plugin.py Outdated

moonyuet and others added 3 commits September 5, 2026 10:21

Update client/ayon_max/api/plugin.py

b826969

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

Update client/ayon_max/api/plugin.py

dc60d89

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

not to storing the publish_families during updating instances but ins…

0a79936

…tead doing it in collecting instances

moonyuet requested a review from BigRoy September 5, 2026 02:26

BigRoy reviewed Sep 7, 2026

View reviewed changes

Comment thread client/ayon_max/api/plugin.py Outdated

pop the families data during the imprint data

7e7402f

moonyuet requested a review from BigRoy September 7, 2026 07:43

BigRoy reviewed Sep 7, 2026

View reviewed changes

Comment thread client/ayon_max/api/lib.py Outdated

pop the families data before the imprint data

cc9af7c

BigRoy reviewed Sep 7, 2026

View reviewed changes

Comment thread client/ayon_max/api/plugin.py Outdated

Update client/ayon_max/api/plugin.py

ef92bf8

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

moonyuet requested a review from BigRoy September 7, 2026 09:28

BigRoy requested changes Sep 7, 2026

View reviewed changes

Comment thread client/ayon_max/api/plugin.py Outdated

clean up

91f641e

moonyuet requested a review from BigRoy September 7, 2026 09:58

moonyuet added 3 commits September 7, 2026 19:27

implement the imprint instance node

57eb83f

remove unused import

8c89f14

return empty list for get_pre_create_attr_defs()

699f17a

BigRoy reviewed Sep 7, 2026

View reviewed changes

Comment thread client/ayon_max/api/plugin.py Outdated

Comment thread client/ayon_max/api/plugin.py Outdated

moonyuet and others added 4 commits September 7, 2026 19:43

Update client/ayon_max/api/plugin.py

d4a13eb

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

Update client/ayon_max/api/plugin.py

199abdb

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

clean up the line

34b6642

clean up the line

3ee228c

moonyuet requested a review from BigRoy September 7, 2026 11:48

BigRoy approved these changes Sep 7, 2026

View reviewed changes

BigRoy requested a lite review from Copilot September 7, 2026 11:52

Copilot started reviewing on behalf of BigRoy September 7, 2026 11:52 View session

Copilot AI reviewed Sep 7, 2026

View reviewed changes

add instance_data['families'] for general MaxCreator

c9d2b0f

BigRoy reviewed Sep 7, 2026

View reviewed changes

Comment thread client/ayon_max/api/plugin.py Outdated

Update client/ayon_max/api/plugin.py

4b98064

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

moonyuet requested a review from LiborBatek September 7, 2026 12:20

LiborBatek requested changes Sep 8, 2026

View reviewed changes

moonyuet added 2 commits September 8, 2026 20:19

do not pop instance_node

3430a3b

wrong camera argument for local rendering

12d4206

moonyuet requested a review from LiborBatek September 8, 2026 14:48

LiborBatek approved these changes Sep 9, 2026

View reviewed changes

Uh oh!

Conversation

moonyuet commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog Description

Additional review information

Testing notes:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iLLiCiTiT Sep 4, 2026

Choose a reason for hiding this comment

Uh oh!

moonyuet Sep 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BigRoy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BigRoy left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BigRoy commented Sep 7, 2026

Uh oh!

Uh oh!

Uh oh!

BigRoy left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

BigRoy Sep 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LiborBatek left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LiborBatek left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

moonyuet commented Sep 4, 2026 •

edited

Loading

BigRoy left a comment •

edited

Loading

BigRoy left a comment •

edited

Loading

LiborBatek left a comment •

edited

Loading