Vray: Implement save file for non-exr format and non-raw exr - #139
Vray: Implement save file for non-exr format and non-raw exr #139moonyuet wants to merge 38 commits into
Conversation
…nt-save-file-action-when-non-exr-format-and-vray-raw-filename-not-used
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
…at-and-vray-raw-filename-not-used' of https://github.com/ynput/ayon-3dsmax into bugfix/138-implement-save-file-action-when-non-exr-format-and-vray-raw-filename-not-used
BigRoy
left a comment
There was a problem hiding this comment.
Code LGTM - needs testing by @LiborBatek
LiborBatek
left a comment
There was a problem hiding this comment.
So here are my findings so far:
- When using Existing Render Instance
I can not pass the File Output path validation and the Repair action does not work/fix anything so publishing is not possible...
Even manually changing the output folder/path didnt do for me...
- When creating fresh new
Renderpublish instance
it produces a publish and renders on the farm but my Publish DL job been pending because of expected files which I have found differ and missing (maybe due to Vray Render Globals Settings (see the pic) but just my assumption)...
And when inspecting the dependencies in DL Monitor:
When manually tweaked (copy and renaming those to maxRenderMain it succesfully finnishes the publish dl job)...
…n-non-exr-format-and-vray-raw-filename-not-used
|
@LiborBatek Please test with exr and other image formats such as png with separate render channels on/off. |
…n-non-exr-format-and-vray-raw-filename-not-used
Is there any publish report for this?
Skipping validation is doable. But let's create separate issue for this as it could have some works to do. |
LiborBatek
left a comment
There was a problem hiding this comment.
Here is the full json report as it fails during the publishing:
…n-non-exr-format-and-vray-raw-filename-not-used
…n-non-exr-format-and-vray-raw-filename-not-used
|
Now the repair fixes the Render Global output path but in the workfile scene (but when published the workfile version actually differs then) e.g. the workfile output path been correctly set to
while isnpecting pre_load_max_script:
So I assume the repair works but we have to repair it to the correct (published workfile version)....which is different then the working version... I hope it does make sense... Some JSONs and script file 3dsmax-publish-report-260710-17-47.json.txt maxrenderMain_metadata.json.txt So the issue remains the same but with different circumstances/ reason... |
We need to introduce the validation to align the directory of AOV and render output. |
There was a problem hiding this comment.
Pull request overview
This PR targets V-Ray render output handling in the 3ds Max AYON integration, specifically to ensure the beauty pass is correctly saved/expected when users render with non-EXR formats or with EXR but “save raw image file” disabled (issue #138).
Changes:
- Adjust V-Ray render saving behavior (
rt.rendSaveFile) so beauty output is saved when not using raw-EXR saving. - Refactor/centralize repair-action attribute gathering for render output directory + multipass setting.
- Update expected-output selection logic for V-Ray in render product collection.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
client/ayon_max/plugins/publish/validate_rendersettings.py |
Refactors repair helpers; adds output-dir consistency checks; updates V-Ray repair/save behavior. |
client/ayon_max/api/lib.py |
Extends workfile-name sync helper to also update/create-context instance keys. |
client/ayon_max/api/lib_rendersettings.py |
Updates V-Ray output filename setup and conditions for rt.rendSaveFile. |
client/ayon_max/api/lib_renderproducts.py |
Updates how V-Ray beauty/AOV output paths are chosen for expected-file generation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…n-non-exr-format-and-vray-raw-filename-not-used
…n-non-exr-format-and-vray-raw-filename-not-used
…n-non-exr-format-and-vray-raw-filename-not-used
LiborBatek
left a comment
There was a problem hiding this comment.
Im not able to succesfully render any frame for some reason..I have also tried to build my test scene from scratch but still failing on rendering phase when inspecting on DL monitor...
Any ideas??
Here is the render log with some errors:
…n-non-exr-format-and-vray-raw-filename-not-used







Changelog Description
This PR is to implement the fix when users do not use exr as image format and raw image file option(see the screenshot) when using vray renders.

Additional review information
Resolves #138
Tested with different renderers(RS etc.) and see if there is some other issues hit.
Testing notes:
New Render Instance
Existing Render Instance