Repository navigation
Make a new commentary line pulse more obviously - #45
Merged
Merged
Conversation
The old highlight was a single subtle ring flash that was easy to miss. A fresh commentary line now pulses a volt-tinted background plus a volt ring three times over ~2s (on top of the slide-in), so live viewers clearly catch the new entry as the feed scrolls to it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The new-commentary highlight was too subtle — a single short border-colour flash that viewers often missed.
Change
A fresh commentary line now pulses three times over ~2s: a volt-tinted background (
color-mixof the volt accent over the card) plus a volt ring, on top of the existing slide-in. The volt accent is the same colour the live badge uses, so it reads as "something just happened."Scoped to
Gamecast/Show.vue'scommentary-enter-activekeyframes — only newly-keyed list items animate, so existing lines never re-pulse on a reload.Verification
Verified the animation in isolation (the dev stack — serve/Reverb/Vite — was stopped at the time, so no end-to-end run this round; the realtime-append path was confirmed in prior work). No logic change, CSS only.
🤖 Generated with Claude Code