fix(pnp): cache package manifest lookups - #7259
Open
the-spyke wants to merge 1 commit into
Open
Conversation
Cache both present and missing package manifests while determining module formats. This avoids repeating filesystem lookups for every loaded JavaScript file, which is particularly expensive on bind-mounted filesystems.
the-spyke
marked this pull request as ready for review
August 15, 2026 21:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Fixes the issue of excess file system operations while resolving the loaded file type (whether it is CJS or ESM).
Resolves #7258
...
How did you fix it?
Added a simple
Mapto cache both positive and negativepackage.jsonlookups. As an additional measure to lower memory consumption I cache only thetypefield, because the rest are not used by the consumers.In my reproduction repo the number of syscalls went from
1,202to just6.Checklist