refactor(application-rs): 统一 workspace clippy 配置并修复告警

application-rs/Cargo.toml

@@ -20,3 +20,19 @@ tracing-appender = { version = "0.2.3" }
 
 prometheus = { version = "0.14.0" }
 ulid = { version = "3.0.0" }
+
+[workspace.lints.rust]
+unsafe_code = "forbid"
+unreachable_pub = "warn"
+missing_docs = "allow"
+
+[workspace.lints.clippy]
+all = { level = "warn", priority = -1 }
+pedantic = { level = "warn", priority = -1 }
+unwrap_used = "warn"
+expect_used = "warn"
+panic = "warn"
+cast_precision_loss = "allow"
+derivable_impls = "allow"
+must_use_candidate = "allow"
+missing_errors_doc = "allow"

application-rs/application-api/Cargo.toml

@@ -5,6 +5,9 @@ version.workspace = true
 edition.workspace = true
 publish.workspace = true
 
+[lints]
+workspace = true
+
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [[bin]]

application-rs/application-api/src/lib.rs

@@ -10,22 +10,27 @@ use std::net::{IpAddr, SocketAddr};
 use std::str::FromStr;
 use std::time::Duration;
 
-mod middleware;
-mod request;
-mod response;
-mod routes;
-mod service;
-mod v1;
+pub mod middleware;
+pub mod request;
+pub mod response;
+pub mod routes;
+pub mod service;
+pub mod v1;
 
 pub struct App;
 
 impl App {
+    /// # Panics
+    ///
+    /// 当 `G_CONFIG.bin_api.listen` 不是合法的 IP 地址时 panic。此为启动期配置错误，
+    /// 预期 fail-fast。
     pub fn listen() -> SocketAddr {
         let api_config = &G_CONFIG.bin_api;
 
         let listen = api_config.listen.as_str();
         let port = api_config.port;
 
+        #[allow(clippy::expect_used)]
         SocketAddr::from((
             IpAddr::from_str(listen).expect("API 监听地址格式无效"),
             port,

application-rs/application-api/src/middleware.rs

@@ -20,12 +20,15 @@ pub async fn tracing_id(
     ctrl: &mut FlowCtrl,
 ) {
     let id = Ulid::generate().to_string();
-    request
-        .headers_mut()
-        .insert("x-request-id", id.parse().unwrap());
-    response
-        .headers_mut()
-        .insert("x-request-id", id.parse().unwrap());
+    let request_id = id
+        .parse()
+        .unwrap_or_else(|_| salvo::http::HeaderValue::from_static("unknown"));
+    request.headers_mut().insert("x-request-id", request_id);
+    response.headers_mut().insert(
+        "x-request-id",
+        id.parse()
+            .unwrap_or_else(|_| salvo::http::HeaderValue::from_static("unknown")),
+    );
 
     let span = tracing::info_span!("http.request", request_id = %id);
     application_kernel::logger::TracingId::attach(&span, &id);
@@ -50,12 +53,11 @@ pub async fn authorization(
         }};
     }
 
-    let auth = match request.headers().get(AUTHORIZATION) {
-        Some(h) => match h.to_str() {
-            Ok(a) => a,
-            Err(_) => abort!(ErrorCode::AuthorizationInvalidFormat),
-        },
-        None => abort!(ErrorCode::AuthorizationHeaderMissing),
+    let Some(header) = request.headers().get(AUTHORIZATION) else {
+        abort!(ErrorCode::AuthorizationHeaderMissing)
+    };
+    let Ok(auth) = header.to_str() else {
+        abort!(ErrorCode::AuthorizationInvalidFormat)
     };
 
     let token = auth.strip_prefix("Bearer ").unwrap_or(auth);

application-rs/application-api/src/request/access_token.rs

@@ -36,7 +36,7 @@ impl Validator for LoginRequest {
             return Ok(LoginRequestParams {
                 platform,
                 third_id: third_id.to_owned(),
-                code: code.to_string(),
+                code: code.clone(),
             });
         }
 
@@ -84,7 +84,7 @@ impl Validator for LoginRefreshRequest {
             return Ok(LoginRefreshRequestParams {
                 platform,
                 third_id: third_id.to_owned(),
-                refresh_token: refresh_token.to_string(),
+                refresh_token: refresh_token.clone(),
             });
         }
 

application-rs/application-api/src/request/totp.rs

@@ -41,10 +41,10 @@ impl TryFrom<Totp> for DetailResponse {
             id: totp.id.to_string(),
             issuer: totp
                 .issuer
-                .to_owned()
+                .clone()
                 .unwrap_or_else(|| "未知发行方".to_string()),
-            username: totp.username.to_owned(),
-            config: totp.config.deref().to_owned().into(),
+            username: totp.username.clone(),
+            config: totp.config.deref().clone().into(),
             code: totp.generate_code()?,
         })
     }
@@ -111,7 +111,7 @@ impl Validator for EditIssuerRequest {
 
         Ok(Self::Data {
             id,
-            issuer: self.issuer.to_owned().unwrap_or_default(),
+            issuer: self.issuer.clone().unwrap_or_default(),
         })
     }
 }

application-rs/application-api/src/response.rs

@@ -79,6 +79,8 @@ impl From<ParseError> for AppErr {
 
 #[cfg(test)]
 mod tests {
+    #![allow(clippy::all)]
+
     use super::*;
     use serde_json::json;
 

application-rs/application-api/src/service/access_token.rs

@@ -13,7 +13,7 @@ pub async fn login(
     let (user_id, access_token_data) = match platform {
         Platform::Wechat => login_wechat(request).await,
         Platform::Huawei => login_huawei(request).await,
-        _ => Err(ErrorCode::ParamsLoginPlatformUnsupported),
+        Platform::Unsupported => Err(ErrorCode::ParamsLoginPlatformUnsupported),
     }?;
 
     let access_token = access_token::update_or_insert(
@@ -134,18 +134,15 @@ async fn get_user_id(
 ) -> Result<u64> {
     let result = third_user::fetch(platform, third_id).await;
 
-    if let Ok(user) = result {
-        return Ok(user.user_id);
-    }
-
-    match result.unwrap_err() {
-        ErrorCode::ParamsThirdUserNotFound => {
+    match result {
+        Ok(user) => Ok(user.user_id),
+        Err(ErrorCode::ParamsThirdUserNotFound) => {
             let user_id = user::insert(None, user::Config::default()).await?;
 
             third_user::insert(platform, third_id, user_id, config).await?;
 
             Ok(user_id)
         }
-        e => Err(e),
+        Err(e) => Err(e),
     }
 }

application-rs/application-api/src/service/totp.rs

@@ -11,7 +11,9 @@ use tracing::error;
 pub async fn all(access_token: &access_token::AccessToken) -> Result<Vec<DetailResponse>> {
     let totp = totp::all(access_token.user_id).await?;
 
-    totp.into_iter().map(|t| t.try_into()).collect()
+    totp.into_iter()
+        .map(std::convert::TryInto::try_into)
+        .collect()
 }
 
 pub async fn sort(

application-rs/application-api/src/v1/access_token.rs

@@ -15,7 +15,7 @@ pub async fn login(request: &mut Request) -> Resp<LoginResponse> {
     let (refresh_token, access_token) = service::access_token::login(&req).await?;
 
     Ok(Response::success(LoginResponse {
-        access_token: access_token.access_token.to_owned(),
+        access_token: access_token.access_token.clone(),
         expired_in: access_token.get_expired_in(),
         refresh_token: refresh_token.refresh_token,
     }))
@@ -30,7 +30,7 @@ pub async fn login_refresh(request: &mut Request) -> Resp<LoginRefreshResponse>
     let (refresh_token, access_token) = service::access_token::login_refresh(&req).await?;
 
     Ok(Response::success(LoginRefreshResponse {
-        access_token: access_token.access_token.to_owned(),
+        access_token: access_token.access_token.clone(),
         expired_in: access_token.get_expired_in(),
         refresh_token: refresh_token.refresh_token,
     }))

application-rs/application-database/Cargo.toml

@@ -5,6 +5,9 @@ version.workspace = true
 edition.workspace = true
 publish.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 application-kernel = { path = "../application-kernel" }
 application-util = { path = "../application-util" }

application-rs/application-database/src/account/access_token.rs

@@ -198,6 +198,8 @@ pub async fn update(mut access_token: AccessToken, data: AccessTokenData) -> Res
 
 #[cfg(test)]
 mod tests {
+    #![allow(clippy::all)]
+
     use super::*;
     use chrono::Duration;
 

application-rs/application-database/src/account/mod.rs

@@ -30,7 +30,7 @@ impl From<&Platform> for &str {
         match v {
             Platform::Wechat => "wechat",
             Platform::Huawei => "huawei",
-            _ => "unsupported",
+            Platform::Unsupported => "unsupported",
         }
     }
 }

application-rs/application-database/src/lib.rs

@@ -52,6 +52,7 @@ impl Pool {
     }
 
     fn connect_mysql(config: &Database) -> MySqlPool {
+        #[allow(clippy::expect_used)]
         let connection_options =
             MySqlConnectOptions::from_str(config.url.as_str()).expect("数据库 URL 格式无效");
 

application-rs/application-database/src/macros.rs

@@ -150,6 +150,8 @@ macro_rules! delete {
 
 #[cfg(test)]
 mod tests {
+    #![allow(clippy::all)]
+
     #[test]
     fn test_insert_macro_sql_validation() {
         let valid_sql = "INSERT INTO users (name) VALUES (?)";

application-rs/application-database/src/tool/totp.rs

@@ -39,7 +39,7 @@ impl Totp {
     pub fn generate_code(&self) -> Result<String> {
         let config = &self.config;
 
-        let secret = Secret::Encoded(config.secret.to_owned())
+        let secret = Secret::Encoded(config.secret.clone())
             .to_bytes()
             .map_err(|e| {
                 error!("TOTP Secret 解码失败: {:?}", e);
@@ -52,8 +52,8 @@ impl Totp {
             1,
             config.period,
             secret,
-            self.issuer.to_owned(),
-            self.username.to_owned(),
+            self.issuer.clone(),
+            self.username.clone(),
         );
 
         totp.generate_current().map_err(|e| {

application-rs/application-kernel/Cargo.toml

@@ -5,6 +5,9 @@ version.workspace = true
 edition.workspace = true
 publish.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 serde = { workspace = true }
 chrono = { workspace = true }

application-rs/application-kernel/src/config.rs

@@ -5,6 +5,7 @@ use std::collections::HashMap;
 use std::sync::LazyLock;
 
 pub static G_CONFIG: LazyLock<Config> = LazyLock::new(|| {
+    #[allow(clippy::expect_used)]
     let config = C::builder()
         .add_source(File::with_name("./config.toml").required(false))
         .add_source(
@@ -16,6 +17,7 @@ pub static G_CONFIG: LazyLock<Config> = LazyLock::new(|| {
         .build()
         .expect("加载配置失败");
 
+    #[allow(clippy::expect_used)]
     config.try_deserialize::<Config>().expect("解析配置失败")
 });
 
@@ -114,11 +116,11 @@ impl Default for AccessToken {
 
 impl AccessToken {
     pub fn get_expired_at(&self) -> DateTime<Local> {
-        Local::now() + chrono::Duration::seconds(self.expired_in as i64)
+        Local::now() + chrono::Duration::seconds(i64::from(self.expired_in))
     }
 
     pub fn get_refresh_expired_at(&self) -> DateTime<Local> {
-        Local::now() + chrono::Duration::seconds(self.refresh_expired_in as i64)
+        Local::now() + chrono::Duration::seconds(i64::from(self.refresh_expired_in))
     }
 }
 

application-rs/application-kernel/src/result.rs

@@ -67,12 +67,14 @@ impl ErrorCode {
         match self {
             Self::Success => "success",
             Self::AuthorizationHeaderMissing => "认证失败: 缺少认证信息,请重新登录",
-            Self::AuthorizationAccessTokenInvalid => "认证失败: 认证信息不正确,请重新登录",
+            Self::AuthorizationAccessTokenInvalid | Self::AuthorizationRefreshTokenInvalid => {
+                "认证失败: 认证信息不正确,请重新登录"
+            }
             Self::AuthorizationInvalidFormat => "认证失败: 认证信息格式不正确,请重新登录",
             Self::AuthorizationPermissionUngranted => "认证失败: 未授权,请勿越权使用",
-            Self::AuthorizationAccessTokenExpired => "认证失败: 认证信息已过期,请重新登录",
-            Self::AuthorizationRefreshTokenInvalid => "认证失败: 认证信息不正确,请重新登录",
-            Self::AuthorizationRefreshTokenExpired => "认证失败: 认证信息已过期,请重新登录",
+            Self::AuthorizationAccessTokenExpired | Self::AuthorizationRefreshTokenExpired => {
+                "认证失败: 认证信息已过期,请重新登录"
+            }
             Self::ParamsJsonInvalid => "参数错误: Json 解析失败,请确认您的参数是否符合规范",
             Self::ParamsLoginPlatformUnsupported => "参数错误: platform 参数值不支持",
             Self::ParamsLoginCodeFormatInvalid => "参数错误: 登录秘钥格式错误",
@@ -94,8 +96,7 @@ impl ErrorCode {
             Self::ParamsShortlinkFormatInvalid => "参数错误: URL 格式不正确",
             Self::ParamsUserSloganLengthInvalid => "参数错误: Slogan 长度应大于 3,请正确填写",
             Self::ParamsUserAvatarLengthInvalid => "参数错误: 头像格式不正确,请正确填写",
-            Self::ParamsThirdConfigNotFound => "参数错误: 您访问的平台暂不支持,请重试或联系管理员",
-            Self::ParamsLoginPlatformThirdIdFormatInvalid => {
+            Self::ParamsThirdConfigNotFound | Self::ParamsLoginPlatformThirdIdFormatInvalid => {
                 "参数错误: 您访问的平台暂不支持,请重试或联系管理员"
             }
             Self::ParamsRefreshTokenNotFound => "参数错误: Refresh Token 未找到",
@@ -134,6 +135,8 @@ impl std::error::Error for ErrorCode {}
 
 #[cfg(test)]
 mod tests {
+    #![allow(clippy::all)]
+
     use super::*;
 
     #[test]

application-rs/application-util/Cargo.toml

@@ -5,6 +5,9 @@ version.workspace = true
 edition.workspace = true
 publish.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 application-kernel = { path = "../application-kernel" }
 

application-rs/application-util/src/http.rs

@@ -18,13 +18,14 @@ pub struct HttpResponse<T> {
 }
 
 static G_CLIENT: LazyLock<Client> = LazyLock::new(|| {
+    #[allow(clippy::expect_used)]
     Client::builder()
         .user_agent("yansongda/application-rs")
         .connect_timeout(Duration::from_secs(1))
         .timeout(Duration::from_secs(3))
         .pool_idle_timeout(Duration::from_secs(30))
         .pool_max_idle_per_host(8)
-        .tcp_keepalive(Duration::from_secs(60))
+        .tcp_keepalive(Duration::from_mins(1))
         .tcp_nodelay(true)
         .build()
         .expect("HTTP 客户端初始化失败")