Skip to content

Implement Python bindings and stabilize test infrastructure #203 #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabrielrusanescu wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Implement Python bindings and stabilize test infrastructure #203 #325

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8ea1c3d
Added Python Bindings for issue 203 (everything that has been done un…
gabrielrusanescu Jul 7, 2026
9f8b98b
Fixed pre-push hooks
gabrielrusanescu Jul 7, 2026
f5e2d4a
Fixing pre-push errors
gabrielrusanescu Jul 7, 2026
531c47a
Stabilize test suite and fix concurrency issues
gabrielrusanescu Jul 8, 2026
bd31749
Fix memory corruption and concurrency issues by refactoring test reso…
gabrielrusanescu Jul 8, 2026
37d0d76
Fixed mod.rs file
gabrielrusanescu Jul 8, 2026
4661bc4
Added python bindings test to ensure functionality
gabrielrusanescu Jul 9, 2026
d3dc9b0
Added variable for compatibility issues
gabrielrusanescu Jul 9, 2026
69aa412
Implemented the solutions from review
gabrielrusanescu Jul 11, 2026
fa15108
Added new changes from review comment
gabrielrusanescu Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .cargo/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
[build]
rustflags = ["--cfg", "rustix_use_libc"]

@radumarias radumarias Jul 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This global --cfg rustix_use_libc is a build-machine workaround baked into every build of the repo, and it's silently dropped exactly where it matters.

Two problems:

  1. Wrong layer. It switches every rustix in every build — including the production FUSE binary — from the linux_raw backend to libc, just to work around the old locked rustix 0.37.28 failing on recent nightly. Cargo.lock still contains rustix 0.37.28; the PR's own instructions-python-bindings/fix_rustix_error.md says the real fix is updating the locked rustix (cargo update -p rustix, or bumping the dependency that pulls 0.37.x). Doing that makes this cfg unnecessary. (The [workspace.dependencies] rustix = "1.1.4" added in the root Cargo.toml doesn't help either — no crate references it with workspace = true, so it pins nothing.)

  2. Silently overridden. Cargo ignores build.rustflags whenever the RUSTFLAGS env var is set — and scripts/check-before-push.sh line 6 does export RUSTFLAGS="-Dwarnings". So the guarded pre-push builds compile without this cfg (hitting the original rustix error on affected toolchains, or silently using a different syscall backend than plain cargo build), and local vs. guarded builds diverge.

Suggest: drop this file, update the locked rustix instead, and scope PYO3_USE_ABI3_FORWARD_COMPATIBILITY to the rencfs-python build (or upgrade pyo3) rather than exporting it repo-wide.

Generated by Claude Code


[env]
PYO3_USE_ABI3_FORWARD_COMPATIBILITY = "1"
Loading