Skip to content

New iterative generators - #661

Merged
maximelucas merged 15 commits into
devfrom
new_generators
Oct 29, 2026
Merged

maximelucas merged 15 commits into
devfrom
new_generators

Conversation

@maximelucas

@maximelucas maximelucas commented Feb 10, 2025 •

Copy link
Copy Markdown
Collaborator

Added three iterative deterministic generators:

Code adapted from the "Higher-order Laplacian Renormalization" repo.

@codecov

codecov Bot commented Feb 10, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.80220% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.92%. Comparing base (6743633) to head (db472dd).

Files with missing lines Patch % Lines
xgi/generators/growth.py 97.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #661      +/-   ##
==========================================
+ Coverage   94.87%   94.92%   +0.04%     
==========================================
  Files          65       66       +1     
  Lines        5382     5473      +91     
==========================================
+ Hits         5106     5195      +89     
- Misses        276      278       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maximelucas

Copy link
Copy Markdown
Collaborator Author

@Marconurisso @MartaMorandini Can you check again that these two functions look correct? I wrote tests only for order=2 and n_iter up to 2, can you add basic ones for another value of order if it's worth it?

@maximelucas
maximelucas marked this pull request as ready for review February 10, 2025 12:14
@maximelucas

Copy link
Copy Markdown
Collaborator Author

I've now also added an NGF function, please check that it's correct and we should add a few simple tests.

@nwlandry

Copy link
Copy Markdown
Collaborator

@maximelucas any updates on this?

@kaiser-dan kaiser-dan added the new feature New feature or request label Feb 26, 2026
@kaiser-dan
kaiser-dan changed the base branch from main to dev February 26, 2026 15:42

@nwlandry nwlandry left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good @maximelucas! Thanks for the contribution. Just some documentation comments to fix before merging.

Comment thread docs/source/api/generators.rst Resolved
Comment thread xgi/generators/growth.py Resolved
Comment thread xgi/generators/iterative.py Resolved
Comment thread xgi/generators/growth.py Resolved
@maximelucas

maximelucas commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator Author

@nwlandry addressed all your comments and fixed a few bugs + new tests.

@nwlandry nwlandry left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @maximelucas! Good to go!

@maximelucas
maximelucas merged commit dac91a7 into dev Oct 29, 2026
16 checks passed
@maximelucas
maximelucas deleted the new_generators branch October 29, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

incorporate pseudofractal generative models incorporate Network-Geometry-with-Flavor

3 participants