Skip to content

fix: type CriticalScript props as script attributes #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gwagjiug wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −1
Open

fix: type CriticalScript props as script attributes #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be226bb
fix: update CriticalScriptProps to extend ScriptHTMLAttributes for be…
gwagjiug Aug 14, 2026
097ddf2
Merge branch 'main' into fix/script-html-attributes
gwagjiug Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vite-plugin-critical-script/global.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
declare module '*?as-critical-script' {
import 'react/jsx-runtime'

interface CriticalScriptProps extends React.HTMLAttributes<HTMLScriptElement> {}
interface CriticalScriptProps extends React.ScriptHTMLAttributes<HTMLScriptElement> {}

/**
* When rendering HTML with React via SSR or SSG in Vite, JS script code is inlined inside the head.
Expand Down
3 changes: 3 additions & 0 deletions packages/vite-plugin-critical-script/script-props.typecheck.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import type CriticalScript from './__fixtures__/sample.ts?as-critical-script'

void ({ async: true } satisfies React.ComponentProps<typeof CriticalScript>)