Skip to content

OpenSSL compat with ML-DSA #10962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kojo1 wants to merge 23 commits into
base: master
Choose a base branch
from
Open

OpenSSL compat with ML-DSA #10962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
c71c2ba
OpenSSL compat with ML-DSA
kojo1 Jul 21, 2026
d9e04a7
Add ML-DSA test coverage for X509_REQ_sign
kojo1 Jul 24, 2026
fa7cda1
PRIVATE_KEY_UNLOCK to X509 sign/set_pubkey
kojo1 Jul 24, 2026
365a9a0
Dynamic buff size based on expected cert size
kojo1 Jul 24, 2026
8629d9d
Explicit prePopulated flag for d2iTryMlDsaKey
kojo1 Jul 30, 2026
2c8ce3f
Size X509 gen buffer from subject public key too
kojo1 Jul 30, 2026
5130e00
Allow NULL md for ML-DSA X509 signing, add test
kojo1 Jul 30, 2026
f6d88bd
Single gate for ML-DSA X509 signing capability
kojo1 Jul 30, 2026
a7d30e2
Reset MlDsaKey between decode attempts in X509_set_pubkey
kojo1 Jul 30, 2026
aea9b8f
PKCS#8 algId check and DER-only typed d2i for ML-DSA
kojo1 Jul 30, 2026
29887a6
Extend ML-DSA compat test coverage to all levels and untested paths
kojo1 Jul 30, 2026
7040f83
Use mldsa_get_oid_sum for draft-aware OID in X509 signing
kojo1 Jul 30, 2026
3cf92c8
Consistency cleanups in new ML-DSA X509 code
kojo1 Jul 30, 2026
9403fa3
Derive WC_MAX_X509_GEN_MLDSA from WC_MAX_X509_GEN
kojo1 Jul 31, 2026
c363238
Use canonical ML-DSA names in new X509/EVP code
kojo1 Jul 31, 2026
1115125
Test X509_set_pubkey with seed and private-only ML-DSA keys
kojo1 Jul 31, 2026
f247487
Guard ML-DSA key/RNG cleanup in tests against Expect short-circuit
kojo1 Jul 31, 2026
4df0330
Reset XFILE handle after every close in ML-DSA tests
kojo1 Jul 31, 2026
04063d8
Free previous algorithm object when d2i repurposes an EVP_PKEY
kojo1 Jul 31, 2026
10b876c
Do not store failed sigType lookup in sigOID
kojo1 Jul 31, 2026
bae7b82
Zeroize pkey.ptr before freeing EVP_PKEY key data
kojo1 Jul 31, 2026
1c67473
Note deliberate md tolerance for ML-DSA X509 signing
kojo1 Jul 31, 2026
50e4d96
Fix error code check
kojo1 Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .wolfssl_known_macro_extras
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -882,7 +882,6 @@ WOLFSSL_MAKE_SYSTEM_NAME_LINUX
WOLFSSL_MAKE_SYSTEM_NAME_WSL
WOLFSSL_MANUALLY_SELECT_DEVICE_CONFIG
WOLFSSL_MDK5
WOLFSSL_MEM_FAIL_COUNT
WOLFSSL_MICROCHIP_AESGCM
WOLFSSL_MLKEM_INVNTT_UNROLL
WOLFSSL_MLKEM_NO_MALLOC
Expand Down
24 changes: 24 additions & 0 deletions src/pk.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6557,6 +6557,18 @@ WOLFSSL_EVP_PKEY* wolfSSL_PEM_read_bio_PrivateKey(WOLFSSL_BIO* bio,
case ED448k:
type = WC_EVP_PKEY_ED448;
break;
#endif
#ifdef WOLFSSL_HAVE_MLDSA
case ML_DSA_44k:
case ML_DSA_65k:
case ML_DSA_87k:
#ifdef WOLFSSL_MLDSA_FIPS204_DRAFT
case DILITHIUM_LEVEL2k:
case DILITHIUM_LEVEL3k:
case DILITHIUM_LEVEL5k:
#endif
type = WC_EVP_PKEY_DILITHIUM;
break;
#endif
default:
type = WOLFSSL_FATAL_ERROR;
Expand Down Expand Up @@ -6714,6 +6726,18 @@ WOLFSSL_EVP_PKEY* wolfSSL_PEM_read_PrivateKey(XFILE fp, WOLFSSL_EVP_PKEY **key,
case ED448k:
type = WC_EVP_PKEY_ED448;
break;
#endif
#ifdef WOLFSSL_HAVE_MLDSA
case ML_DSA_44k:
case ML_DSA_65k:
case ML_DSA_87k:
#ifdef WOLFSSL_MLDSA_FIPS204_DRAFT
case DILITHIUM_LEVEL2k:
case DILITHIUM_LEVEL3k:
case DILITHIUM_LEVEL5k:
#endif
type = WC_EVP_PKEY_DILITHIUM;
break;
#endif
default:
type = WOLFSSL_FATAL_ERROR;
Expand Down
Loading
Loading