Add ability to disable annotations including canvas appearance-data - #968
Closed
yuliya-ivaniukovich wants to merge 1 commit into
Closed
Add ability to disable annotations including canvas appearance-data#968yuliya-ivaniukovich wants to merge 1 commit into
yuliya-ivaniukovich wants to merge 1 commit into
Conversation
wojtekmaj
self-requested a review
March 23, 2022 08:03
wojtekmaj
reviewed
Mar 23, 2022
Owner
There was a problem hiding this comment.
Beautiful work!
Some comments I have:
annotationModemust be documented.- Having more unit tests would be great. I'll gladly help out.
- This technically deprecates
renderFormsin favor of much more powerfulannotationMode, so renderForms is to be marked as deprecated (this one can be on me)
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
April 20, 2022 08:36
be758b5 to
1a9897f
Compare
wojtekmaj
force-pushed
the
main
branch
6 times, most recently
from
October 24, 2022 14:44
1f184c5 to
ef56712
Compare
wojtekmaj
force-pushed
the
main
branch
7 times, most recently
from
November 10, 2022 10:44
b14700a to
416e96c
Compare
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
February 12, 2023 19:18
36a36d4 to
e249af6
Compare
wojtekmaj
force-pushed
the
main
branch
3 times, most recently
from
March 2, 2023 14:22
d14ccb7 to
744f655
Compare
wojtekmaj
force-pushed
the
main
branch
7 times, most recently
from
May 14, 2024 09:32
2d488c1 to
a077571
Compare
wojtekmaj
force-pushed
the
main
branch
5 times, most recently
from
June 10, 2024 23:04
1f758cc to
ce6db03
Compare
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
June 13, 2024 08:22
42a8c3c to
0d68fee
Compare
wojtekmaj
force-pushed
the
main
branch
4 times, most recently
from
July 9, 2024 15:54
d0aabb2 to
736f3f3
Compare
|
How can I help to get this merged? |
About (3) deprecating renderForms: we actually need to keep both renderForms and annotationMode as they serve distinct purposes.
Example: to show filled non-editable input {
renderForms: false,
annotationMode: ENABLE_STORAGE,
} |
Owner
|
Superseded by #1998 as this PR had to be rebased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #963