-
-
Notifications
You must be signed in to change notification settings - Fork 184
ci: experimental MSYS2/MinGW test run #1122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
211edd3
ci: skip uv install on MinGW in tests session
henryiii c29c17a
ci: add experimental MSYS2/MinGW test run
henryiii b998182
test: account for MinGW POSIX venv layout in bin-path tests
henryiii c841b39
test: xfail uv-backend tests under MinGW until #1117
henryiii 1819b91
ci: touch up comments on uv and msys
henryiii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -75,8 +75,54 @@ jobs: | |
| include-hidden-files: true | ||
| if-no-files-found: error | ||
|
|
||
| # No uv CLI exists in any MSYS2 repo (the msys `uv` package only ships the | ||
| # uv_build backend), so the uv backend is exercised via the standalone uv | ||
| # binary from setup-uv | ||
| msys2: | ||
| runs-on: windows-latest | ||
| continue-on-error: true | ||
| defaults: | ||
| run: | ||
| shell: msys2 {0} | ||
| steps: | ||
| - uses: actions/checkout@v6.0.3 | ||
| with: | ||
| persist-credentials: false | ||
| - uses: msys2/setup-msys2@v2.32.0 | ||
| with: | ||
| msystem: MINGW64 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we recommend using UCRT64 environment, because MINGW64 is about to be deprecated
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks! I'll try to make a follow up soon |
||
| update: true | ||
| # Inherit the runner PATH so the standalone uv (added to GITHUB_PATH | ||
| # by setup-uv, which runs after this step) is visible to MinGW Python | ||
| path-type: inherit | ||
| install: >- | ||
| mingw-w64-x86_64-python | ||
| mingw-w64-x86_64-python-pip | ||
| mingw-w64-x86_64-python-virtualenv | ||
| mingw-w64-x86_64-gcc | ||
| - name: Setup uv | ||
| uses: astral-sh/setup-uv@v8.2.0 | ||
| - name: Install Nox-under-test | ||
| run: python -m pip install . | ||
| # Force virtualenv so the session venv stays a MinGW interpreter | ||
| # (_IS_MINGW=True). uv stays on PATH, so the uv-backend tests still | ||
| # build real uv venvs from within MinGW | ||
| - name: Run tests under MinGW | ||
| run: | | ||
| pyver=$(python -c "import sys; print('{}.{}'.format(*sys.version_info))") | ||
| echo "MSYS2 MinGW Python: $pyver" | ||
| python -c "import shutil; print('uv discovered at:', shutil.which('uv'))" | ||
| nox --session "tests-$pyver" --force-venv-backend virtualenv -- --durations=10 | ||
| - name: Save coverage report | ||
| uses: actions/upload-artifact@v7 | ||
| with: | ||
| name: coverage-${{ github.job }} | ||
| path: .coverage.* | ||
| include-hidden-files: true | ||
| if-no-files-found: error | ||
|
|
||
| coverage: | ||
| needs: build | ||
| needs: [build, msys2] | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v6.0.3 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but what about https://packages.msys2.org/base/mingw-w64-uv? it may be broken a bit (msys2/MINGW-packages#21091), but it exists