-
Notifications
You must be signed in to change notification settings - Fork 16
Fix crashes on 1.18.2 #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1.18.2
Are you sure you want to change the base?
Changes from 15 commits
1c8cc73
5cc1b43
e98cfdb
a5accda
9eb857f
daef43c
bba0e8c
2e49153
272fecf
13b8bbe
e108672
20cfb6d
8c8d816
f3cbf1c
e8d5d64
75dc9f8
abf022c
fc25df1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,11 @@ | ||
| # Things | ||
| ## Original mod | ||
| * Original mod: https://www.curseforge.com/minecraft/mc-mods/things-fabric | ||
| * Original source code: https://github.com/wisp-forest/things | ||
|
|
||
| [](https://www.curseforge.com/minecraft/mc-mods/things-fabric) | ||
| [](https://modrinth.com/mod/things) | ||
| [](https://github.com/glisco03/things/releases) | ||
| [](https://discord.gg/xrwHKktV2d) | ||
| This is a modification for things 0.2.18+1.18 fixing some issues and adding 1.19 fixes that can be ported. | ||
|
|
||
| ## Overview | ||
|
|
||
| Things is a collection of random trinkets, items and features that I feel enhance the Vanilla experience in a non-instrusive way. Among its features are the | ||
| *Enchanted Wax Gland* which lets you travel very quickly in water, the *Displacement Tome* which is essentially a Warp Book remake, the *Bater Wucket* which is an | ||
| infinite Water Bucket and many more | ||
|
|
||
| ## Credits | ||
| - **Pois1x** for making the textures | ||
| - **naschhorn** for helping with the Almanac | ||
| - **pvpTurtle** for contributing ideas | ||
| ## Fixed in 0.2.19+1.18 | ||
| - Now using fixed version of owo-lib (0.7.3+1.18) | ||
| - Added deepslate glowstone fixture | ||
| - Fixed Broken watch recipe error in logs (see this to know how to craft it https://github.com/wisp-forest/things/issues/43) | ||
| - Fixed crash when generating chunks (https://github.com/wisp-forest/things/issues/41) | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,11 @@ version = "${project.mod_version}+${project.minecraft_base_version}" | |
| group = project.maven_group | ||
|
|
||
| repositories { | ||
|
|
||
| flatDir { | ||
| dirs 'owo-lib_local_repo' | ||
| } | ||
|
Comment on lines
+12
to
+14
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe this too? and some other stuff to be able to merge it in upstream
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure, it won't compile without local libs since they aren't available on maven.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The way you have it currently it won't compile either, since you didn't check the libs directory into source control. In any case, I'd much prefer this to use the actual maven, if and when I publish the backported owo version
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well it did build that way but I agree ot would be a lot better to get the libs from maven. |
||
|
|
||
| maven { url "https://maven.shedaniel.me/" } | ||
|
|
||
| maven { url "https://maven.wispforest.io/"} | ||
|
|
||
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| { | ||
| "variants": { | ||
| "facing=down": { | ||
| "model": "things:block/deepslate_glowstone_fixture" | ||
| }, | ||
| "facing=up": { | ||
| "model": "things:block/deepslate_glowstone_fixture", | ||
| "x": 180 | ||
| }, | ||
| "facing=west": { | ||
| "model": "things:block/deepslate_glowstone_fixture", | ||
| "x": 90, | ||
| "y": 90 | ||
| }, | ||
| "facing=east": { | ||
| "model": "things:block/deepslate_glowstone_fixture", | ||
| "x": 90, | ||
| "y": 270 | ||
| }, | ||
| "facing=south": { | ||
| "model": "things:block/deepslate_glowstone_fixture", | ||
| "x": 90 | ||
| }, | ||
| "facing=north": { | ||
| "model": "things:block/deepslate_glowstone_fixture", | ||
| "x": 90, | ||
| "y": 180 | ||
| } | ||
| } | ||
| } |
Uh oh!
There was an error while loading. Please reload this page.