Problems after replacing the code editor

[gviabcua]

Winter CMS Build

1.2.10+

PHP Version

8.2

Database engine

MySQL/MariaDB

Plugins installed

No response

Issue description

Hello!
After replacing the code editor to 1.2.10, it became very inconvenient to edit the code. I am rolling back to 1.2.9 in order to work normally. From the main things I noticed:

• undoing the previous operation after switching tabs does not work correctly
• the beginning and end of the html tag are not highlighted
• the combination ctrl+shift+d does not work
• the combination ctrl+shift+f does not work
• constant blinking when switching from tab to tab
• you cannot drag partitions, files and urls from the cms block
• the save indicator lights up when switching tabs. Even if there have been no changes
• is it possible to add the default theme that was in the previous editor?

Thank you

Steps to replicate

Problem on old and clean new projects.
Upgrading/Installing to 1.2.10+

Workaround

No response

[LukeTowers]

@gviabcua can you specify what you're expecting to happen for each of those? Ideally with screenshots. As far as I'm aware all of the existing themes were replicated with Monaco, which one were you looking for in particular? There are several important security updates so it's important you don't stay on 1.2.9.

[gviabcua]

@LukeTowers I am recorded few videos with thises problems https://drive.google.com/drive/folders/1J5nblGlI2ZtGXrKVlJ6chXGimXJRRZ5L

[LukeTowers]

@gviabcua those issues should be fixed on the latest develop branch, can you check & verify?

[gviabcua]

@gviabcua those issues should be fixed on the latest develop branch, can you check & verify?

@LukeTowers Nothing has changed.

winter/storm                  dev-develop 21e5110
winter/wn-backend-module      dev-develop f3ef1de         
winter/wn-cms-module          dev-develop 7c2a30e        
winter/wn-system-module       dev-develop 8f0c4da

[LukeTowers]

@gviabcua my apologies, I hadn't pushed the commit from my local yet: a626956, should be available now.

[gviabcua]

@LukeTowers
I tested the fix. The result is below:

• undoing the previous operation after switching tabs does not work correctly - OK
• the beginning and end of the html tag are not highlighted - OK
• the combination ctrl+shift+d does not work - OK
• the combination ctrl+shift+f does not work - OK
• constant blinking when switching from tab to tab - OK
• you cannot drag partitions, files and urls from the cms block - OK
• the save indicator lights up when switching tabs. Even if there have been no changes - OK
• is it possible to add the default theme that was in the previous editor? - Not all the theme edits have been transferred, but it's much better now.

I have a request. Please don't close this ticket. I'll test it in production for a couple more days and then I'll reply.

winter/storm                        dev-develop 21e5110 Winter CMS Storm Library
winter/wn-backend-module            dev-develop b8e2c5d Backend module for Winter CMS
winter/wn-cms-module                dev-develop 325716c CMS module for Winter CMS
winter/wn-system-module             dev-develop 8f0c4da System module for Winter CMS

[gviabcua]

@LukeTowers Found new bug. A php start tag has appeared that prevents you from cutting the entire contents of the file and then pasting it in properly

[gviabcua]

@LukeTowers After changing color via css-picker no indicator of file changing

[mjauvin]

One annoyance I found is that when you click on a button outside of the editor, it doesn't actually do the action other than removing focus from the editor field. You have to click a second time on the button (e.g. Update / Save form buttons)