Skip to content

Implement column type "Short user name" #2948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YeDemirkiran wants to merge 10 commits into
base: master
Choose a base branch
from
+51 −1
Open

Implement column type "Short user name" #2948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
90f133f
Add new column type "Short user name"
YeDemirkiran Jun 22, 2026
27093cc
Implement the new Short user name column
YeDemirkiran Jun 22, 2026
f2213c1
Allocate ShortUserName only once
YeDemirkiran Jun 22, 2026
00c2cbd
Merge branch 'master' into short-user-name
YeDemirkiran Jun 22, 2026
373f715
Merge branch 'master' into short-user-name
YeDemirkiran Jun 23, 2026
4737b54
Add Short username column update function
YeDemirkiran Jun 23, 2026
add8940
Merge branch 'master' into short-user-name
YeDemirkiran Jun 24, 2026
fc26f55
Merge branch 'master' into short-user-name
YeDemirkiran Jun 25, 2026
1a9cbab
Free ShortUsernameText upon node removal
YeDemirkiran Jun 25, 2026
c5b5c24
Merge branch 'short-user-name' of github.com:YeDemirkiran/systeminfor…
YeDemirkiran Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion SystemInformer/include/proctree.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,9 @@
#define PHPRTLC_START_KEY 104
#define PHPRTLC_MITIGATION_POLICIES 105
#define PHPRTLC_SERVICES 106
#define PHPRTLC_SHORT_USERNAME 107

#define PHPRTLC_MAXIMUM 107
#define PHPRTLC_MAXIMUM 108
#define PHPRTLC_IOGROUP_COUNT 9

#define PHPN_WSCOUNTERS 0x1
Expand Down Expand Up @@ -159,6 +160,7 @@
#define PHPN_STARTKEY 0x800000
#define PHPN_SERVICES 0x1000000
#define PHPN_USERHANDLES 0x2000000
#define PHPN_SHORTUSERNAME 0x4000000

// begin_phapppub
typedef struct _PH_PROCESS_NODE
Expand Down Expand Up @@ -309,6 +311,7 @@ typedef struct _PH_PROCESS_NODE
PPH_STRING MitigationPoliciesText;
PPH_STRING ServicesText;
PPH_STRING ServerSiloText;
PPH_STRING ShortUsernameText;

// Graph buffers
PH_GRAPH_BUFFERS CpuGraphBuffers;
Expand Down
47 changes: 47 additions & 0 deletions SystemInformer/proctree.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@ VOID PhInitializeProcessTreeList(
PhAddTreeNewColumn(hwnd, PHPRTLC_START_KEY, FALSE, L"Start key", 120, PH_ALIGN_LEFT, ULONG_MAX, 0);
PhAddTreeNewColumn(hwnd, PHPRTLC_MITIGATION_POLICIES, FALSE, L"Mitigation policies", 180, PH_ALIGN_LEFT, ULONG_MAX, 0);
PhAddTreeNewColumn(hwnd, PHPRTLC_SERVICES, FALSE, L"Services", 180, PH_ALIGN_LEFT, ULONG_MAX, 0);
PhAddTreeNewColumn(hwnd, PHPRTLC_SHORT_USERNAME, FALSE, L"Short user name", 140, PH_ALIGN_LEFT, ULONG_MAX, 0);
Comment thread
YeDemirkiran marked this conversation as resolved.

PhCmInitializeManager(&ProcessTreeListCm, hwnd, PHPRTLC_MAXIMUM, PhpProcessTreeNewPostSortFunction);
PhInitializeTreeNewFilterSupport(&FilterSupport, hwnd, ProcessNodeList);
Expand Down Expand Up @@ -693,6 +694,7 @@ VOID PhpRemoveProcessNode(
PhClearReference(&ProcessNode->ProcessStartKeyText);
PhClearReference(&ProcessNode->MitigationPoliciesText);
PhClearReference(&ProcessNode->ServicesText);
PhClearReference(&ProcessNode->ShortUsernameText);

PhDeleteGraphBuffers(&ProcessNode->CpuGraphBuffers);
PhDeleteGraphBuffers(&ProcessNode->PrivateGraphBuffers);
Expand Down Expand Up @@ -1910,6 +1912,27 @@ static VOID PhpUpdateProcessNodeServices(
}
}

static VOID PhpUpdateProcessNodeShortUsername(
_Inout_ PPH_PROCESS_NODE ProcessNode
)
{
if (!FlagOn(ProcessNode->ValidMask, PHPN_SHORTUSERNAME))
{
PhClearReference(&ProcessNode->ShortUsernameText);

if (ProcessNode->ProcessItem->UserName)
{
wchar_t* backslash = wcsrchr(ProcessNode->ProcessItem->UserName->Buffer, L'\\');
if (backslash)
ProcessNode->ShortUsernameText = PhCreateString(backslash + 1);
else
ProcessNode->ShortUsernameText = PhCreateString(ProcessNode->ProcessItem->UserName->Buffer);
Comment thread
dmex marked this conversation as resolved.
}
Comment thread
YeDemirkiran marked this conversation as resolved.

SetFlag(ProcessNode->ValidMask, PHPN_SHORTUSERNAME);
}
}

#define SORT_FUNCTION(Column) PhpProcessTreeNewCompare##Column
#define BEGIN_SORT_FUNCTION(Column) static int __cdecl PhpProcessTreeNewCompare##Column( \
_In_ const void *_elem1, \
Expand Down Expand Up @@ -2976,6 +2999,19 @@ BEGIN_SORT_FUNCTION(Services)
}
END_SORT_FUNCTION

BEGIN_SORT_FUNCTION(ShortUserName)
{
PhpUpdateProcessNodeShortUsername(node1);
PhpUpdateProcessNodeShortUsername(node2);
sortResult = PhCompareStringWithNullSortOrder(
node1->ShortUsernameText,
node2->ShortUsernameText,
ProcessTreeListSortOrder,
TRUE
);
}
END_SORT_FUNCTION

BOOLEAN NTAPI PhpProcessTreeNewCallback(
_In_ HWND hwnd,
_In_ PH_TREENEW_MESSAGE Message,
Expand Down Expand Up @@ -3163,6 +3199,7 @@ BOOLEAN NTAPI PhpProcessTreeNewCallback(
SORT_FUNCTION(StartKey),
SORT_FUNCTION(MitigationPolicies),
SORT_FUNCTION(Services),
SORT_FUNCTION(ShortUserName),
};
_CoreCrtNonSecureSearchSortCompareFunction sortFunction;

Expand Down Expand Up @@ -4698,6 +4735,16 @@ BOOLEAN NTAPI PhpProcessTreeNewCallback(
}
}
break;
case PHPRTLC_SHORT_USERNAME:
{
PhpUpdateProcessNodeShortUsername(node);

if (node->ShortUsernameText)
{
getCellText->Text = PhGetStringRef(node->ShortUsernameText);
}
}
break;
default:
return FALSE;
}
Expand Down
Loading