Fix options page redraw artifacts#2937
Open
bitRAKE wants to merge 1 commit into
Open
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
The risky part is the global side effect in Best upstream shape is maybe one of these:
This fix is still useful evidence that identifies the affected class of pages and confirms the mechanism. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes dirty/stale background artifacts when switching to some plugin Options pages.
The fix:
WS_CLIPCHILDRENon plugin option pages whose group-box regions exposed stale backing pixels:Problem
Some Options pages showed stale pixels from previously selected pages inside group-box areas. The controls from the previous page were not active; this was a redraw artifact.
Confirmed affected pages:
Investigation signals
The issue was narrowed down through several visual checks:
Several probes helped isolate the cause:
WS_EX_TRANSPARENTto affected group boxes did not fix the artifact.WS_CLIPCHILDRENalone did not fix the artifact.WS_CLIPCHILDRENon the affected page roots produced the correct visual result.Validation