Repository navigation
Conversation
CI report —
|
| Workflow | Result | Time | Run |
|---|---|---|---|
| CI | ✅ success | 21m21s | #10 |
| Docs | ✅ success | 0m25s | #84 |
CI
✅ posix/ipc
- dApp exit:
0 - Indications received:
7
✅ posix/tcp
- dApp exit:
0 - Indications received:
7
✅ zmq/ipc
- dApp exit:
0 - Indications received:
7
✅ zmq/tcp
- dApp exit:
0 - Indications received:
7
zmq/ipc
- ✅ 1 RAN - 1 dApp: indications=
5dapppeer=t11 ran=ran-solo sub=1 indications=5 seq=[0..4] dropped=0 (0%) age_ms(avg=0 max=0 @seq=0) hist[<=1:5 2-5:0 6-10:0 >10:0]
- ✅ 1 RAN - 2 dApps: dApp#1 ind=
5sub=1, dApp#2 ind=6sub=2, RAN saw2dApps - ✅ 2 RANs - 1 dApp: from ran-a ind=
5, from ran-b ind=5
zmq/tcp
- ✅ 1 RAN - 1 dApp: indications=
5dapppeer=default ran=ran-solo sub=1 indications=5 seq=[0..4] dropped=0 (0%) age_ms(avg=0.4 max=1 @seq=3) hist[<=1:5 2-5:0 6-10:0 >10:0]
- ✅ 1 RAN - 2 dApps: dApp#1 ind=
5sub=1, dApp#2 ind=6sub=2, RAN saw2dApps - ✅ 2 RANs - 1 dApp: from ran-a ind=
5, from ran-b ind=5
Full-loop latency
Full-loop latency benchmark (N=1076 after 50 warmup)
All values in microseconds (μs). Link: zmq, transport: ipc, encoding: ASN.1 APER.
| # | Description | Tags | mean | p50 | p99 | max |
|---|---|---|---|---|---|---|
| 1 | Collect indication data | RECORD_BEGIN to ENCODE_E3SM_BEGIN |
0.13 | 0.12 | 0.30 | 0.54 |
| 2 | Create & encode indication | ENCODE_E3SM_BEGIN to ENCODE_E3SM_DONE |
0.98 | 0.94 | 1.65 | 4.83 |
| 3 | Encode E3AP (indication) | EMIT_ENTER to ENQUEUE, then DEQUEUE to ENCODE_E3AP_DONE |
2.58 | 2.38 | 5.43 | 20.28 |
| 4 | Queuing (indication) | ENQUEUE to DEQUEUE |
5.95 | 7.04 | 13.78 | 24.94 |
| 5 | Delivery (indication) | ENCODE_E3AP_DONE to SEND_DONE |
0.38 | 0.27 | 1.41 | 21.85 |
| 6 | E3 wire (RAN -> dApp) | SEND_DONE to RECV |
41.95 | 41.21 | 61.35 | 69.55 |
| 7 | Decode E3AP (indication) | RECV to DECODE_E3AP_DONE |
1.53 | 1.51 | 5.65 | 24.18 |
| 8 | libe3 dispatch (indication) | DECODE_E3AP_DONE to DELIVER_BEGIN |
0.13 | 0.12 | 0.23 | 0.41 |
| 9 | Decode indication | DELIVER_BEGIN to DECODE_E3SM_DONE |
0.51 | 0.53 | 0.71 | 0.93 |
| 10 | Process data | DECODE_E3SM_DONE to ENCODE_E3SM_BEGIN |
0.04 | 0.04 | 0.05 | 0.10 |
| 11 | Create & encode control | ENCODE_E3SM_BEGIN to ENCODE_E3SM_DONE |
0.35 | 0.35 | 0.49 | 0.75 |
| 12 | Encode E3AP (control) | EMIT_ENTER to ENQUEUE, then DEQUEUE to ENCODE_E3AP_DONE |
3.31 | 3.23 | 5.61 | 19.97 |
| 13 | Queuing (control) | ENQUEUE to DEQUEUE |
12.34 | 11.68 | 19.32 | 225.60 |
| 14 | Delivery (control) | ENCODE_E3AP_DONE to SEND_DONE |
6.18 | 5.95 | 18.25 | 23.43 |
| 15 | E3 wire (dApp -> RAN) | SEND_DONE to RECV |
42.96 | 42.12 | 61.77 | 126.52 |
| 16 | Decode E3AP (control) | RECV to DECODE_E3AP_DONE |
2.74 | 2.65 | 4.95 | 19.30 |
| 17 | libe3 dispatch (control) | DECODE_E3AP_DONE to DECODE_E3SM_BEGIN |
0.76 | 0.71 | 1.08 | 28.69 |
| 18 | Decode & handle control | DECODE_E3SM_BEGIN to DECODE_E3SM_DONE |
0.34 | 0.33 | 0.46 | 1.31 |
| Total | Total round-trip | 123.80 | 121.80 | 152.84 | 357.39 |
ubuntu-latest, Release build, ZMQ + IPC, ASN.1 APER.
These numbers are measured inside a GitHub Actions container and should be treated as an upper bound on E3AP's and the library's own latency, not a representative deployment measurement.
Docs
Doxygen warnings
0 warning(s) in the files this pull request changes, which fail the check; 119 more elsewhere, which do not. The full list is in the job log and the doxygen-warnings artifact of the Docs workflow.
Gaps in files this pull request does not change, by file:
| Warnings | File |
|---|---|
| 37 | include/libe3/sm_interface.hpp |
| 17 | include/libe3/logger.hpp |
| 17 | swig/libe3_swig.hpp |
| 17 | swig/e3_dapp_session.hpp |
| 9 | include/libe3/dapp_subscription_state.hpp |
| 7 | include/libe3/lockfree_queue.hpp |
| 6 | include/libe3/mpmc_queue.hpp |
| 1 | include/libe3/error_codes.h |
| 1 | include/libe3/libe3.hpp |
| 1 | src/connector/zmq_connector.hpp |
Ready to merge (fast-forward only)
A maintainer can land the reviewed commits with:
git fetch origin
git checkout main && git merge --ff-only ff4feb99e167fcb1bd0ecfa93da72ce7d86e3bfa && git push origin mainHead: ff4feb99e167fcb1bd0ecfa93da72ce7d86e3bfa (branch fix/97-repeat-subscription). If --ff-only fails as non-fast-forward, the branch must be rebased on the latest main.
One comment per PR, rewritten in place once every workflow for
ff4feb9finished.
d2c8c0e to
3ca4c67
Compare
b67557c to
bfcd006
Compare
3ca4c67 to
1713b1b
Compare
87c6b47 to
d79a331
Compare
1713b1b to
b69184e
Compare
A dApp that subscribed again to a RAN function it already had was told "positive" with the existing subscription id, and the RAN kept the stored lists and periodicity. But the response echoed the lists and periodicity of the repeat, so it described a subscription that does not exist (#97). A dApp that subscribed again to change its periodicity read the new value in the answer and kept the old rate. A repeat is still answered with the existing id, and the lists and periodicity in the response are now the ones the RAN holds. A repeat the RAN refuses leaves the subscription as it was, and one made after subscriptionTime ran out still renews it in place. If the subscription ended between the check and the lookup, the response reports no lists and no periodicity, which the grammar reads as "not reported". To change a subscription a dApp deletes it and subscribes again, which is also the only form that behaves alike on libe3, Aerial's agent and OCUDU. Nothing changes on the wire, in the C API or in libe3py. Specification and guide: 03 says a repeat does not change the subscription and how to change one; the integrator guide gets the row and its pointers, which follow the added lines; the Word edition is rebuilt. The interop page corrects what it said about Aerial, whose agent adds a subscription for every request and only whose dApp manager refuses a second one; calls OCUDU's one per repeat a defect; drops the row that recorded the echo; and gets a ledger row. Test: a dApp that subscribes again with other lists and another periodicity gets the same id with the stored ones, the RAN keeps one subscription and starts the SM once; a repeat with an identifier the function lacks is refused and changes nothing; a dApp that registered again is answered with what it asked for. The test fails on the code before this change. VERSION 0.4.2. Assisted-by: Claude:claude-sonnet-5-5 Signed-off-by: Thecave3 <thecave003@gmail.com>
d79a331 to
0fbf154
Compare
b69184e to
ff4feb9
Compare
Summary
A libe3 RAN answers a repeated subscription (same dApp, same RAN function) with the existing subscription id, as it always did, and kept the lists and periodicity of the first request. But the response echoed the lists and periodicity of the repeat, so a dApp that subscribed again to change its periodicity read the new value and kept the old rate (#97).
What a RAN does now
subscriptionTimeran out still renews the subscription in place.Nothing changes on the wire, in the C API or in libe3py. The interop page also corrects what it said about Aerial: its agent has no check for an existing subscription and adds one for every request. Only the dApp manager of the Aerial sample apps stops at one, before it sends anything. OCUDU adds one per repeat until a per-dApp limit, then refuses with
resourceExhausted; the page now calls that a defect.What a user sees
What is not done
resourceExhausted.Commits
core: answer a repeated subscription with the one the RAN holds, with its test, the specification and guide changes, the interop page changes and the version bump.Notes for review
VERSIONis 0.4.2. 0.4.1 is in Remove a dApp that vanished, and register a dApp again when it lost the RAN #146.test_subscription_repeat_e2e) fails on the code before this change, at the assertion that the repeat's response has the stored list.e3_interface.cppfollow the added lines.Type of change
Linked issue
Closes #97
Twin-repo coordination
docs/interop.md.Paired PR(s): none needed. OAI's E3 agent does not need a rebuild for this change.
Checks run locally
In an Ubuntu 24.04 container with
./build_libe3:-r -t(Release) and-g -t(Debug): all tests pass.--docs-strict: no warning.git log --merges origin/main..HEADis empty.