fix(tui): the sky dims with the room instead of going dark under the card [spec 10] - #126
Merged
Merged
Conversation
…card [spec 10] While an ask was on the spotlight card, the kitty raster layer (the figure and the ripple) was deleted outright - the sky going dark under every consent read as the interface breaking (user report). The rasters now step down WITH the room: the figure repaints faded by the same 0.55 as hush(), the ripple repaints in the hushed accent with its height clipped to end above the card, and either raster leaves only when the card's own rows would collide with it - a kitty image composites above text cells and must never cover the card. The card's footprint is computed from the renderer's own width/chrome math (cardRows/cardTopRow in dock.ts); stagePlan and waveRowsFor make the keep/dim/yield decision pure and unit-tested. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements specs/spec10/10-tui.md (§3.2-B spotlight amendment — the sky dims with the room).
What
Field report: whenever a consent/question card appears, the pixel figure and the ripple stardust vanish from the sky panel — the raster layer was deleted outright while hushed, because kitty images composite above text cells and could cover the card. A sky that goes dark under every ask reads as the interface breaking.
Now the rasters step down with the room instead of leaving:
hush()(HUSH_FADE, reusingencodeFigurePng's existing fade channel and cached per pose+state).waveRowsFor).cardRows/cardTopRowindock.ts, wrapping included); a raster is deleted only when the card's rows would actually reach it (stagePlan) — short windows keep the old behavior, everything else keeps the sky.Verification
pnpm test(root, includes the newcardRows/stagePlan/waveRowsForunit coverage) and the TUI tree's ownbun run typecheck(the CItuijob's command) — green; oxlint green.AI coding brief
🤖 Generated with Claude Code