Skip to content

feat(music): prefer vocal tracks, widen the pick's turn budget [spec 03-01] - #123

Merged
wine-fall merged 1 commit into
mainfrom
zachg-0812--music-prefer-vocals
Aug 12, 2026
Merged

feat(music): prefer vocal tracks, widen the pick's turn budget [spec 03-01]#123
wine-fall merged 1 commit into
mainfrom
zachg-0812--music-prefer-vocals

Conversation

@wine-fall

Copy link
Copy Markdown
Owner

Implements specs/spec03/03-01-brain-harness.md (music discovery §2.3/§2.5).

What

  • FIND_MUSIC_INSTRUCTION now asks the pick task to choose a song with
    vocals
    by default; instrumental-only tracks (light/background music, lofi,
    piano versions) only when the listener explicitly asks for instrumental.
  • DEFAULT_MAX_TURNS for the pick task goes 6 → 8: a real pick under the new
    guidance can spend 5 searches before submitting, and 6 turns starved one run
    into a null pick (= a silent music break).

Evidence

Two real smoke runs (murmur-smoke, real Haiku brain + real yt-dlp + ffmpeg
probe) on the adversarial scenario — late night, listener asks for "something
soft", the case that used to land on instrumental:

  • pick 1: 李健《贝加尔湖畔》 — vocal, resolve + probe ok, announce written
  • pick 2: 陳綺貞《旅行的意義》 — vocal, resolve + probe ok, announce written

Gates: pnpm test (761), pnpm run typecheck, oxlint — all green.
Peer review (codex gpt-5.5, xhigh): 1 finding, 1 applied (comment carried
edit-history phrasing), 0 dismissed.

AI coding brief

Original request: The listener kept getting instrumental/light music from
the radio's music breaks and wants every pick to be a song with vocals.

Manual interventions: The user called out that the first pass edited the
main checkout directly without the murmur-ship flow; the work was redone
through the full pipeline (worktree, gates, smoke, review). That correction is
now a persistent memory.

Retro: Route any code edit through murmur-ship from the first keystroke —
the "it's just one prompt line" exemption doesn't exist. The smoke run also
paid for itself immediately: it caught the turn-budget starvation a
prompt-only diff would have shipped.

🤖 Generated with Claude Code

…03-01]

The pick instruction now asks for a song with vocals by default —
instrumental-only tracks (light/background music, lofi, piano versions)
only when the listener explicitly asks. A real pick under this guidance
can spend 5 searches before submitting, so the default turn budget goes
from 6 to 8 to keep headroom.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@wine-fall
wine-fall merged commit df9416a into main Aug 12, 2026
3 checks passed
@wine-fall
wine-fall deleted the zachg-0812--music-prefer-vocals branch August 12, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant