Skip to content

Update eslint config#1253

Closed
edg2s wants to merge 1 commit into
masterfrom
eslint
Closed

Update eslint config#1253
edg2s wants to merge 1 commit into
masterfrom
eslint

Conversation

@edg2s

@edg2s edg2s commented Apr 3, 2020

Copy link
Copy Markdown
Member

No description provided.

@edg2s

edg2s commented Apr 3, 2020

Copy link
Copy Markdown
Member Author

Failures appear unrelated to the patch.

Pchelolo
Pchelolo reviewed Apr 3, 2020
View reviewed changes
Comment thread package.json
"eslint-config-wikimedia": "^0.13.1",
"eslint-plugin-jsdoc": "^15.8.0",
"eslint-plugin-json": "^1.4.0",
"eslint": "^6.8.0",

@Pchelolo Pchelolo Apr 3, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately we can't do that yet. We still need to be able to run this on node6

@Pchelolo

Pchelolo commented Apr 3, 2020

Copy link
Copy Markdown
Contributor

We unfortunately can't do this yet, we still need to be able to run this on node 6. eslint is not a prod dependency, but we want to be able to run tests on node 6 as well.

@edg2s

edg2s commented Apr 24, 2020

Copy link
Copy Markdown
Member Author

We could disable linting tests on 6, they only need to be checked in one environment...

@wikimedia-helper-bot-for-github

wikimedia-helper-bot-for-github Bot commented May 9, 2020

Copy link
Copy Markdown

👋 Hi @edg2s,

Thank you for contributing to Wikimedia! This Github repository is a read-only mirror.
The project uses Gerrit for code review.
Please submit your pull request to Gerrit, so your code changes can be reviewed.

If you are interested in sticking around within the Wikimedia community, please take a look at https://www.mediawiki.org/wiki/New_Developers
Thanks in advance!

@Pchelolo Pchelolo reopened this May 9, 2020
@Pchelolo

Pchelolo commented Feb 7, 2022

Copy link
Copy Markdown
Contributor

Superseded by #1299

@Pchelolo Pchelolo closed this Feb 7, 2022
@edg2s edg2s deleted the eslint branch February 8, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Pchelolo Pchelolo Pchelolo left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@edg2s @Pchelolo