Skip to content

Restore active custom element constructor map entries after construction #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annevk merged 1 commit into from
Jul 17, 2026
Merged

Restore active custom element constructor map entries after construction #1494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions dom.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6978,6 +6978,10 @@ null, or a {{CustomElementRegistry}} object <var>registry</var> (default "<code>
<li><p>Let <var>C</var> be <var>definition</var>'s
<a for="custom element definition">constructor</a>.

<li><p>Let <var>previousRegistry</var> be the <a>surrounding agent</a>'s
<a for="similar-origin window agent">active custom element constructor map</a>[<var>C</var>]
<a for=map>with default</a> null.

<li><p><a for=map>Set</a> the <a>surrounding agent</a>'s
<a for="similar-origin window agent">active custom element constructor map</a>[<var>C</var>] to
<var>registry</var>.
Expand Down Expand Up @@ -7060,11 +7064,13 @@ null, or a {{CustomElementRegistry}} object <var>registry</var> (default "<code>
<var>prefix</var>, "<code>failed</code>", null, and <var>registry</var>.
</ol>

<li>
<p><a for=map>Remove</a> the <a>surrounding agent</a>'s
<a for="similar-origin window agent">active custom element constructor map</a>[<var>C</var>].
<li><p>If <var>previousRegistry</var> is null, then <a for=map>remove</a> the
<a>surrounding agent</a>'s
<a for="similar-origin window agent">active custom element constructor map</a>[<var>C</var>].

<p class=note>Under normal circumstances it will already have been removed at this point.
<li><p>Otherwise, <a for=map>set</a> the <a>surrounding agent</a>'s
<a for="similar-origin window agent">active custom element constructor map</a>[<var>C</var>] to
<var>previousRegistry</var>.
Comment on lines +7067 to +7073

@keithamus keithamus Jul 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HTML spec has these two steps combined, but DOM has them as 2 discrete steps. Any particular reason why?

@annevk annevk Jul 17, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oversight; I've now made it two steps in HTML as well.

</ol>

<li>
Expand Down