Fix for the leg_detector opencv3 bug - #48
Conversation
The cv::ml package has been rewritten. I just changed the code to accomodate the new api, maybe this does not conform to the way the new cv::ml should be used...
In opencv3 the predict_prob method was removed from cv::ml::RTrees.
|
It seems I cannot make Travis build. Can someone with superior knowledge take over, please? |
The dependency on the people_msgs package should be enough. This removes warnings for the leg_detector and people_tracking_filter when building with catkin_make_isolated and catkin build.
|
Oh! I get it... Travis does not run Xenial (16.04) and Kinetic does not support Trusty (14.04). So we cannot test Kinetic code on Travis... |
|
Sorry for the delay. #49 is finally ready for the review. Once it's merged you may rebase your PR to run test against. |
|
@130s I tried rebasing on your k/update_travis branch, but for some reason I get the error with the haarcascade file in Travis: On another note, I totally screwed something up when rebasing, that is why I closed the pull request. I will open it when #49 has been merged. |
|
Ok, so OpenCV was just updated to 3.2.0. I tried changing the hardcoded location, now I get a pass on Travis. |
2 participants
This is a fix for #44 and in turn #47. I have changed the CvMat C-style calls to the corresponding C++style of opencv3. Also the fuzzy probability call predict_prob no longer exists, so I implemented a replacement. I have not done a comparison test with Indigo, as I have no working Indigo-installation, but it looks good to me on 16.04+Kinetic.